Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] [Guided tours] Add missing auto start parameter in the user interface of tours #43690

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

obuisard
Copy link
Contributor

@obuisard obuisard commented Jun 21, 2024

Summary of Changes

The autostart parameter has been introduced in Joomla 5.1 to facilitate the autostart feature and mainly the welcome tour.

This PR goes a step further and adds the ability to make a tour auto-start-able in the interface.
The purpose of the PR is to just add the ability to modify the parameter from the edit view.
The functionality for auto-starting tours is presented in a separate PR #43814.

image

Testing Instructions

Go to System -> Guided Tours.
Pick a tour.
Check that the option is present.
Set it on.
Duplicate the tour.
Make sure the duplicated tour replicates the original tour auto-start value.

Note. The welcome tour, at present (until the addition of the joint PR), if set to auto-start, will run once and be automatically set to auto-start: false after the run.
Tours set to auto start will not start automatically with this PR alone.

Actual result BEFORE applying this Pull Request

No auto start parameter.

Expected result AFTER applying this Pull Request

The auto start parameter can be changed from the tour edit view.

Link to documentations

Please select:

  • [x ] Documentation link for docs.joomla.org: Edit Tour

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Added auto start option
Added autostart parameter
Added autostart label translation
Revert test code
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.2-dev labels Jun 21, 2024
Reorganise attributes of the field

Co-authored-by: Brian Teeman <brian@teeman.net>
@RickR2H
Copy link
Member

RickR2H commented Jun 28, 2024

I have tested this item ✅ successfully on 535cd9a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43690.

1 similar comment
@hans2103
Copy link
Contributor

I have tested this item ✅ successfully on 535cd9a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43690.

@Quy
Copy link
Contributor

Quy commented Jul 4, 2024

@obuisard Change Draft status?

@obuisard
Copy link
Contributor Author

obuisard commented Jul 4, 2024

@obuisard Change Draft status?

We are waiting for the second PR that complements it. I don't want this one to be merged before that Thank you @Quy

@obuisard obuisard changed the title Add Guided Tours auto start parameter in the user interface of tours [5.2] [Guided tours] Add missing auto start parameter in the user interface of tours Jul 18, 2024
@obuisard obuisard marked this pull request as ready for review July 20, 2024 04:59
@Quy Quy changed the title [5.2] [Guided tours] Add missing auto start parameter in the user interface of tours [5.2] [Guided tours] Add missing auto start parameter in the user interface of tours Jul 22, 2024
@Quy
Copy link
Contributor

Quy commented Jul 22, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43690.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 22, 2024
@Hackwar Hackwar merged commit f47b621 into joomla:5.2-dev Jul 24, 2024
3 checks passed
@Hackwar Hackwar added this to the Joomla! 5.2.0 milestone Jul 24, 2024
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 24, 2024
@Hackwar
Copy link
Member

Hackwar commented Jul 24, 2024

Thank you for your contribution! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators PR-5.2-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants