Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add captive prompts for the rest of MFA methods #38082

Merged
merged 4 commits into from
Jun 18, 2022
Merged

Add captive prompts for the rest of MFA methods #38082

merged 4 commits into from
Jun 18, 2022

Conversation

nikosdion
Copy link
Contributor

Pull Request for comment #37912 (comment).

Ping @Kostelano @richard67

Summary of Changes

Adds captive login prompts for these MFA methods:

  • Backup Codes
  • TOTP (Authenticator Code)
  • YubiKey

The rest of the methods already had it:

  • Email
  • Fixed
  • WebAuthn

Testing Instructions

  • Set up MFA using authentication code and YubiKey
  • Note down your Backup Codes
  • Log out and log back in

Actual result BEFORE applying this Pull Request

Choosing to validate with backup codes, TOTP or YubiKey would only display a text box without any help text to help you understand what to do.

Expected result AFTER applying this Pull Request

There is help text above the text box explaining how to obtain the code and proceed with the MFA.

Documentation Changes Required

None

Adds language strings

These three methods didn't have a captive prompt language string. I added three strings.

Addresses comment #37912 (comment)

Adds captive login prompts for these MFA methods:
* Backup Codes
* TOTP (Authenticator Code)
* YubiKey

The rest of the methods already had it:
* Email
* Fixed
* WebAuthn
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels Jun 17, 2022
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: Brian Teeman <brian@teeman.net>
@richard67
Copy link
Member

I have tested this item ✅ successfully on b5c7d4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38082.

1 similar comment
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on b5c7d4a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38082.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38082.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 17, 2022
@fancyFranci fancyFranci merged commit 1273361 into joomla:4.2-dev Jun 18, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 18, 2022
@fancyFranci
Copy link
Contributor

Thank you for the improvement!

@Quy Quy added this to the Joomla 4.2.0 milestone Jun 18, 2022
heelc29 added a commit to heelc29/joomla that referenced this pull request Jun 23, 2022
zero-24 added a commit to joomlagerman/joomla that referenced this pull request Jul 21, 2022
#2483)

* remove and add strings

in existing files

* add 10 new files

plg_multifactorauth_*

* translation plg_multifactorauth_email

* translation plg_multifactorauth_fixed

* translation plg_multifactorauth_totp

* translation plg_twofactorauth_yubikey

* translation plg_multifactorauth_webauthn

* fix #2486

* file header

* add strings

joomla/joomla-cms#38082

* fix #2506

* unification Passwort-Manager

* fix one Authentifikator

* fix year

* fix wording

* fix joomla.ini

* fix joomla.ini

* fix joomla.ini

* fix z. B.

* fix com_users.ini

translation

* fix translation

* fix Backup-Code

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_email.sys.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_totp.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* revert

* wording

* wording

* translation

* Update administrator/language/de-DE/plg_multifactorauth_fixed.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.sys.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_fixed.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_fixed.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_fixed.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_fixed.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Apply suggestions from code review

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Apply suggestions from code review

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Apply suggestions from code review

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

* Update administrator/language/de-DE/plg_multifactorauth_email.sys.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_totp.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_totp.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_totp.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* fix link

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* fix

* fix

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>

* fix

* Update administrator/language/de-DE/plg_multifactorauth_fixed.sys.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_fixed.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Apply suggestions from code review

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/plg_multifactorauth_yubikey.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update language/de-DE/com_users.ini

Co-authored-by: Dieter Ziller <max123kl@ziller.de>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_twofactorauth_totp.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_twofactorauth_totp.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_twofactorauth_yubikey.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_twofactorauth_yubikey.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update language/de-DE/com_users.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_email.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_email.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/com_users.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_fixed.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_totp.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update language/de-DE/com_users.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_fixed.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_fixed.sys.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update administrator/language/de-DE/plg_multifactorauth_totp.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* add eo

* Update administrator/language/de-DE/plg_multifactorauth_webauthn.ini

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>

* Update language/de-DE/com_users.ini

* Update administrator/language/de-DE/com_users.ini

* fix

weil alle einen punkt haben

Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Dieter Ziller <max123kl@ziller.de>
Co-authored-by: Tobias Zulauf <zero-24@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants