Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] update message #38075

Merged
merged 3 commits into from
Jun 16, 2022
Merged

[4.2] update message #38075

merged 3 commits into from
Jun 16, 2022

Conversation

brianteeman
Copy link
Contributor

image

COM_JOOMLAUPDATE_VIEW_DEFAULT_POTENTIALLY_DANGEROUS_PLUGIN_CONFIRM_MESSAGE="Are you sure you want to ignore the warnings about potentially incompatible extensions and proceed with the update?"

COM_JOOMLAUPDATE_VIEW_DEFAULT_NON_CORE_PLUGIN_CONFIRMATION="Acknowledge the warnings about potentially incompatible extensions and proceed with the update."

changes the first one to also use the word acknowledge and not ignore

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.2-dev labels Jun 16, 2022
@richard67
Copy link
Member

I have tested this item ✅ successfully on ed1aa32

Ok, more consistent now.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38075.

@heelc29
Copy link
Contributor

heelc29 commented Jun 16, 2022

I have tested this item ✅ successfully on ed1aa32


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38075.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38075.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 16, 2022
@richard67 richard67 merged commit 5489fff into joomla:4.2-dev Jun 16, 2022
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 16, 2022
@richard67
Copy link
Member

Thanks all.

@richard67 richard67 added this to the Joomla 4.2.0 milestone Jun 16, 2022
@brianteeman brianteeman deleted the acknowledge branch June 16, 2022 16:58
@richard67
Copy link
Member

@roland-d @fancyFranci Ouch .. I just see that I should not have merged it because I was one of the testers ... but it's such a simple change that I think it should be ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants