Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2] Workflow Notification no recipient #37747

Merged
merged 9 commits into from
Jul 3, 2022
Merged

Conversation

brianteeman
Copy link
Contributor

@brianteeman brianteeman commented May 5, 2022

PR for #37744

Test Setup Instructions

  • Enable workflows in the content options with Basic as the default
  • Edit all the Transitions so they have notifications enabled and set the Usergroups to Manager
  • Create a new user in the usergroup manager
  • Create a new article and save & close
  • Edit an article and change the stage

Test 1

  • Check that the new user is receiving the notification emails for the change in state
    only proceed to test 2 & 3 when you are sure that you are gettig the email

Test 2

  • Log in as the manager user and go to Messaging and in the My Settings lock the inbox
  • log back in as your super user
  • edit the previous article again and change the stage

Before this PR

No notifications sent and no message displayed
image

After this PR

No notifications sent and a message is displayed - I am very open to suggestions for a better message
image

Test 3

In the transition remove the usergroup
image

Before this PR

No notifications sent and no message displayed
image

After this PR

No notifications sent and a message is displayed - I am very open to suggestions for a better message
image

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.1-dev labels May 5, 2022
@brianteeman brianteeman changed the base branch from 4.1-dev to 4.2-dev June 22, 2022 08:35
@brianteeman brianteeman changed the title [4.1] Workflow Notification no recipient [4.2] Workflow Notification no recipient Jun 22, 2022
@brianteeman
Copy link
Contributor Author

rebased to 4,2 now that there will be no further 4.1 releases

@Quy Quy removed the PR-4.1-dev label Jun 22, 2022
@Kostelano
Copy link
Contributor

I have tested this item ✅ successfully on 359dfb9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37747.

@joomla-bot
Copy link
Contributor

This pull requests has been automatically converted to the PSR-12 coding standard.

@brianteeman
Copy link
Contributor Author

brancg updated to restart drone

@alikon
Copy link
Contributor

alikon commented Jul 2, 2022

I have tested this item ✅ successfully on da184b3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37747.

@alikon
Copy link
Contributor

alikon commented Jul 2, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37747.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jul 2, 2022
@roland-d roland-d merged commit 81da883 into joomla:4.2-dev Jul 3, 2022
@roland-d
Copy link
Contributor

roland-d commented Jul 3, 2022

Thank you.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 3, 2022
@roland-d roland-d added this to the Joomla! 4.2.0 milestone Jul 3, 2022
@brianteeman brianteeman deleted the wf2 branch July 3, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants