-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to save an article from the frontend without being redirected (#37312) #37362
Conversation
I have tested this item ✅ successfully on 6ffe565 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37362. |
@bembelimen Is this a new feature and so has to go into 4.2? Or can it be considered a progressive enhancement so it's ok for 4.1.x (likely 4.1.2)? |
4.2 please |
@magnussinger Could you rebase the PR to 4.2-dev? Let us know if we shall help with that. |
@richard67 yes sure |
@magnussinger You can add the new language string |
@roland-d thanks for the info, I added it |
@roland-d I just tested your idea and it didn't work, I would leave it like I did it |
@magnussinger Why would it not work? I see no reason why it would not work. Looking further we could improve it better like this:
This works for me. |
Yes, you are right this works for me too. I edited it |
@ChristineWk Could you test again with the latest changes? Thanks in advance. |
I have tested this item ✅ successfully on 2b900dc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37362. |
I have tested this item ✅ successfully on 2b900dc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37362. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37362. |
Thank you Magnus |
Yes, congratulations @magnussinger to your (as far as I know) first merged pull request for Joomla CMS. |
Thank you @fancyFranci and @richard67 and all the others for helping me with this. It was indeed my first pull request, and I'm looking forward to some more :) |
joomla/joomla-cms#36591 + joomla/joomla-cms#37362 + joomla/joomla-cms#37404 - (позже был Revert PR) joomla/joomla-cms#37453 + joomla/joomla-cms#37583 + joomla/joomla-cms#37459 + joomla/joomla-cms#36751 + joomla/joomla-cms#36752 + joomla/joomla-cms#37912 + joomla/joomla-cms#37838 + joomla/joomla-cms#38002 + joomla/joomla-cms#38036 - (только для en-GB, у нас давно исправлено) joomla/joomla-cms#38009 + joomla/joomla-cms#38064 + joomla/joomla-cms#37911 + joomla/joomla-cms#38065 + joomla/joomla-cms#38075 + joomla/joomla-cms#38071 + joomla/joomla-cms#38080 + joomla/joomla-cms#38082 + joomla/joomla-cms#38092 + joomla/joomla-cms#38113 + joomla/joomla-cms#38121 + joomla/joomla-cms#37910 + joomla/joomla-cms#38165 + joomla/joomla-cms#37747 +
Pull Request for Issue #37312.
Summary of Changes
Added a new button to the article edit form on the frontend. It allows the user to save the article without closing the form. This corresponds with the functionality of the backend.
Testing Instructions
Edit an article from the frontend, the button will be on the bottom and you can save the article without being redirected
Actual result BEFORE applying this Pull Request
Only the ability to save the article and get redirected to it right afterward
Expected result AFTER applying this Pull Request
You can choose to only save the article and stay inside the edit form
Documentation Changes Required
None