Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#27221] Improvements for batch processing #29

Merged
merged 47 commits into from
Jan 3, 2012
Merged

[#27221] Improvements for batch processing #29

merged 47 commits into from
Jan 3, 2012

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Dec 5, 2011

This is the pull request coinciding with http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27221.

This improves the batch processing throughout the CMS for Joomla! 2.5. Included in this pull request:

  • All components: Improved ACL checks for create and edit permissions
  • com_banners: Full batch processing implementation (category, language, and client)
  • com_contact: Full batch processing implementation (access, category, language, and linked user)
  • com_content: Handles featured articles during copy process (see
  • com_modules: Full batch processing implementation (access, copy/move between positions, language)
  • com_newsfeeds: Full batch processing implementation (access, category, and language)
  • com_users: Implement unused batch processing code for group assignment

This item also references CMS issues [#26905] and [#26986].

One TODO item remains as of this time: Implementing batch processing logic for menu associations (I've been looking at this, and hope to have something ready soon)

Also, to assist with conforming to coding standards, in many of the files that I've edited, I've applied the coding standard from the Platform into my edited files.

This change edits several library files as well; a separate pull request for the Platform is forthcoming.

Michael Babker added 29 commits December 19, 2011 02:39
In the controller batch method, build an array of contexts for each item that is being edited and pass it to the model; the model forwards this array to each method where permissions are checked on the context versus the extension root.  Applied concept to batchAccess and batchLanguage, but error reporting needs to be handled now.
Added language and category widgets from library and created a widget to batch edit the client
Add JHtmlUser to the libraries and moved the group selection list from com_users there.  Added a userlist function to display a list of users (primary user will be com_contact to handle linked users).  Added HTML to display the linked user field, but still needs processing code.
@infograf768
Copy link
Member

Copying Module and changing language without changing position just changes the language of the module chosen

@chdemko
Copy link
Contributor

chdemko commented Dec 30, 2011

The pull request cannot be merged
Could you make a pull request on the platform for the changes?

@mbabker
Copy link
Contributor Author

mbabker commented Dec 30, 2011

The changes to JControllerForm are already in the platform (not sure why it didn't merge in on the last platform merge). The fix for the user list I'll take care of later.

Merged from master, so should merge cleanly for a short time.

@infograf768
Copy link
Member

Don't want to be pushy, but this patch includes a lot of new language strings and we get nearer to beta2 /RC.
We will have to declare a language freeze at some time.

@mbabker
Copy link
Contributor Author

mbabker commented Dec 31, 2011

I've just pushed the last set of fixes for the issues @chdemko reported.

Can we merge soon?

@infograf768
Copy link
Member

Saw more errors. Commented on tracker.

@infograf768
Copy link
Member

Modules copying still broken when choosing language and no change in position

@chdemko
Copy link
Contributor

chdemko commented Jan 2, 2012

Why did you rename administrator/components/{com_users → com_banners}/helpers/html/index.html ? (should be a copy?)

@mbabker
Copy link
Contributor Author

mbabker commented Jan 2, 2012

No idea why it's being tracked as a rename. I'll sort that once I'm back on my computer.

-Michael

Please pardon any errors, this message was sent from my iPhone.

On Jan 2, 2012, at 2:24 PM, Christophe Demko reply@reply.github.com wrote:

Why did you rename administrator/components/{com_users → com_banners}/helpers/html/index.html ? (should be a copy?)


Reply to this email directly or view it on GitHub:
#29 (comment)

chdemko added a commit that referenced this pull request Jan 3, 2012
[#27221] Improvements for batch processing
@chdemko chdemko merged commit a0c6adf into joomla:master Jan 3, 2012
roland-d pushed a commit that referenced this pull request Feb 16, 2016
Check for empty jquery object before value length

Thanks @richard67
wilsonge pushed a commit that referenced this pull request Apr 7, 2016
wilsonge pushed a commit that referenced this pull request Jan 23, 2017
wilsonge pushed a commit that referenced this pull request May 31, 2017
* codestyle

* code style

* codestyle

* codestyle

* codestyle

* thanks @wojsmol

* corrections - thanks @Quy

* corrections - thanks @Quy

* oops

* make @Quy happy

* Update article.xml

* Remove space

* Update config.xml (#14)

* Update filter.xml (#15)

* Update config.xml (#16)

* Update profile.xml (#17)

* Update application.xml (#18)

* Update article.xml (#19)

* Update filter_articles.xml (#20)

* Update config.xml (#24)

* Update config.xml (#23)

* Update filter_fields.xml (#22)

* Update filter_featured.xml (#21)

* Update override.xml (#25)

* Update config.xml

* Update config.xml (#26)

* Update itemadmin_alias.xml (#30)

* Update itemadmin.xml (#29)

* Update item.xml (#27)

* Update item_alias.xml (#28)

* Update itemadmin_url.xml (#31)

* Update module.xml (#32)

* Update plugin.xml (#33)

* Update config.xml (#34)

* Update link.xml (#35)

* Update config.xml (#36)

* Update style.xml (#38)

* Update config.xml (#37)

* Update note.xml (#42)

* Update group.xml (#41)

* Update filter_debuggroup.xml (#40)

* Update config.xml (#39)

* corrections for @andrepereiradasilva

* gotya
wilsonge pushed a commit that referenced this pull request Aug 22, 2017
* update to the latest news on Joomla 4.0

* Change markup (#29)
bembelimen referenced this pull request in bembelimen/joomla-cms Apr 26, 2018
* Corrected the code style.

1. Replaced the wrong class doc comment with an example format in
\administrator\components\com_workflow\Helper\WorkflowHelper.php. Change
the example format with the relevant content.
2. Rest I corrected the alignment.

* Changes return

replace the class doc exmple format with correct one :)
richard67 referenced this pull request in richard67/joomla-cms Apr 3, 2020
obuisard pushed a commit to obuisard/joomla-cms that referenced this pull request Feb 21, 2023
* fix EOF

* fix filter forms

fix default sort
sort order dropdown like table columns
fix sort state ->published

* fix manifest

lowercase name (see. joomla#37387)
indentation (spaces vs. tabs)

* cleanup component provider

component do not use SiteRouter and Category
MacJoom pushed a commit that referenced this pull request May 23, 2023
* Convert the content plugins to service providers

* functions

* namespaces

* doc

* get application from plugin (#29)

* get application from plugin

* Revert pagenavigation

---------

Co-authored-by: heelc29 <66922325+heelc29@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants