Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a new link on the module manager page to add a module for that menutype #41

Merged
merged 3 commits into from
Dec 16, 2011
Merged

Conversation

eddieajau
Copy link
Contributor

Solution for:
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=27379

This code is actually pretty neat because it allows you to pre-populate any module parameter when creating a new module. Could have a wealth of other applications.

Test plan:

  1. Add a new menu type
  2. Check that this link appears in the menu manager list against the new menu "**Add a module for this menu type."
  3. Click link and ensure you go to a new menu page and the menutype is populated. Save and check details.
  4. Create other modules and edit other modules and ensure the "menutype" behaves as expected.

@eddieajau
Copy link
Contributor Author

The changes to the language file are because I sorted it (thought it would be in alpha order already, whoops). Only adding the COM_MENUS_ADD_MENU_MODULE="Add a module for this menu type." key.

@infograf768
Copy link
Member

Mistake in the ini file.
A comment has been moved away from its position.
; in the following string
; %1$s is for module title, %2$s is for access-title, %3$s is for position
Trying now to make a working SVN patch as eclipse does not like

@infograf768
Copy link
Member

new patch on tracker

@eddieajau
Copy link
Contributor Author

Bad patch. Fixed it by hand.

chdemko added a commit that referenced this pull request Dec 16, 2011
Added a new link on the module manager page to add a module for that menutype
@chdemko chdemko merged commit d968264 into joomla:master Dec 16, 2011
wilsonge added a commit that referenced this pull request Apr 7, 2016
wilsonge pushed a commit that referenced this pull request May 31, 2017
* codestyle

* code style

* codestyle

* codestyle

* codestyle

* thanks @wojsmol

* corrections - thanks @Quy

* corrections - thanks @Quy

* oops

* make @Quy happy

* Update article.xml

* Remove space

* Update config.xml (#14)

* Update filter.xml (#15)

* Update config.xml (#16)

* Update profile.xml (#17)

* Update application.xml (#18)

* Update article.xml (#19)

* Update filter_articles.xml (#20)

* Update config.xml (#24)

* Update config.xml (#23)

* Update filter_fields.xml (#22)

* Update filter_featured.xml (#21)

* Update override.xml (#25)

* Update config.xml

* Update config.xml (#26)

* Update itemadmin_alias.xml (#30)

* Update itemadmin.xml (#29)

* Update item.xml (#27)

* Update item_alias.xml (#28)

* Update itemadmin_url.xml (#31)

* Update module.xml (#32)

* Update plugin.xml (#33)

* Update config.xml (#34)

* Update link.xml (#35)

* Update config.xml (#36)

* Update style.xml (#38)

* Update config.xml (#37)

* Update note.xml (#42)

* Update group.xml (#41)

* Update filter_debuggroup.xml (#40)

* Update config.xml (#39)

* corrections for @andrepereiradasilva

* gotya
yvesh pushed a commit to yvesh/joomla-cms that referenced this pull request Jun 18, 2017
Update Codeception to version 2.2.2
bembelimen referenced this pull request in bembelimen/joomla-cms Apr 26, 2018
wilsonge referenced this pull request in wilsonge/joomla-cms Jul 10, 2018
wilsonge pushed a commit that referenced this pull request Jul 4, 2019
richard67 referenced this pull request in richard67/joomla-cms Apr 3, 2020
ditsuke added a commit to ditsuke/joomla-cms that referenced this pull request Nov 15, 2021
Merged from pull request joomla#41 from joomla-projects/lock-table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants