Bug fix 1.7.3: SQL error when saving a module

[eddieajau]

Saving a module produces an SQL error due to incorrect usage of the query builder. JDatabaseQuery::values takes a whole tuple of values or an array of tuples (which differs from the columns method which can add to the list of columns with subsequent calls).

Patch also adds some other common files to .gitignore.

NOTE: Error is occurring against the master git platform, not Joomla's copy of /libraries/joomla/.

[dextercowley]

Andrew, is there a tracker issue associated with this? Thanks. Mark

On Thu, Dec 8, 2011 at 1:42 AM, Andrew Eddie
reply@reply.github.com
wrote:

Saving a module produces an SQL error due to incorrect usage of the query builder.  JDatabaseQuery::values takes a whole tuple of values or an array of tuples (which differs from the columns method which can add to the list of columns with subsequent calls).

Patch also adds some other common files to .gitignore.

You can merge this Pull Request by running:

 git pull https://github.com/eddieajau/joomla-cms bugs

Or you can view, comment on it, or merge it online at:

 #32

-- Commit Summary --

• Fix SQL when trying to save a module due to query build error.
• Add extra ignore filters for common files.

-- File Changes --

M .gitignore (6)
M administrator/components/com_modules/models/module.php (5)

-- Patch Links --

 https://github.com/joomla/joomla-cms/pull/32.patch
 https://github.com/joomla/joomla-cms/pull/32.diff

---

Reply to this email directly or view it on GitHub:
#32

[eddieajau]

No. The problem is actually more widespread. I'll ping you about it.

[eddieajau]

Closing.