Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the postinstall to the latest news on Joomla 4.0 #17549

Merged
merged 2 commits into from
Aug 22, 2017

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 15, 2017

Summary of Changes

Update the postinstall to the latest news on Joomla 4.0 for PHP fixes #17547

Testing Instructions

Install Joomla on an non php 7 install

Expected result

Postinstall poping up

Actual result

postinstall come only when you are on lower than 5.5.9

Documentation Changes Required

New minimum as of https://developer.joomla.org/news/704-looking-forward-with-joomla-4.html

@brianteeman
Copy link
Contributor

Do we need the comment about ext/mysql? Isn't that completely removed in PHP 7

@mbabker
Copy link
Contributor

mbabker commented Aug 15, 2017

It's correct. It's saying ext/mysql support is dropped and to use MySQL you have to use one of the other adapters.

@brianteeman
Copy link
Contributor

OK

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 7146496


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17549.

@Quy
Copy link
Contributor

Quy commented Aug 17, 2017

I have tested this item ✅ successfully on e9f31bc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17549.

@CiverBlack
Copy link

CiverBlack commented Aug 22, 2017

I have tested this item ✅ successfully on e9f31bc

I tried the public release and could reproduce the problem. With the patched version it works.
@icampus


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17549.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla 3.8.0 milestone Aug 22, 2017
@ghost
Copy link

ghost commented Aug 22, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 22, 2017
@wilsonge wilsonge merged commit fd27076 into joomla:staging Aug 22, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 22, 2017
@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 22, 2017
@zero-24 zero-24 deleted the 40postinstall branch August 22, 2017 16:40
@zero-24 zero-24 modified the milestones: Joomla 4.0, Joomla 3.8.0 Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0 Postinstall Check Update
7 participants