Coding style. PHP constants true, false, and null MUST be in lower case. #13010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepereiradasilva
approved these changes
Nov 25, 2016
|
this is fine by code review there is no travis error here, anyone can restart travis in this PR? |
|
Restarted travis as requested |
|
thanks |
|
@marcochirienti we need to take out the changes in |
|
Ok, i'm sorry, but i'm new to this world. Should i remove changes to this file and send a new pull request? |
restore restore.php
|
I have tested this item ✅ successfully on 920e697 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13010. |
|
I have tested this item ✅ successfully on 920e697 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13010. |
|
I have tested this item ✅ successfully on 920e697 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13010. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13010. |
joomla-cms-bot
added
Unit/System Tests
and removed
RTC
|
Thanks merged |
roland-d
added a commit
to roland-d/joomla-cms
that referenced
this pull request
Nov 25, 2016
* staging: (98 commits) Coding style. PHP constants true, false, and null MUST be in lower case. (joomla#13010) Removing duplicated AS in sql query (joomla#13006) Fixed typo in comment (joomla#12992) Correcting strings in TFA Google plugin (joomla#12980) code style changes (joomla#12986) Error in sr-YU installation ini file (joomla#12984) New DateTime picker (replaces calendar) (joomla#11138) Export of Banners Tracks Does Not Export the Banner Name fix rues get data (joomla#12763) Added Feature items filter to mod_articles_news (joomla#12547) fix them all (joomla#12943) a11y regression fix (joomla#12935) Set correct component id for system links (joomla#12938) Fix for Undefined offset in Content History preview popup (joomla#12791) remove tab on meta charset (joomla#12895) JSession patched to set session _state to 'inactive' when session is closed. (joomla#12928) [JHtmlNumber::bytes] Format number according to language (joomla#12929) Update edit.php (joomla#12818) Update default.xml (joomla#12917) Adding the ability to use the global value for character count in newsfeeds (joomla#12869) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The PHP keywords MUST be in lower case. The PHP constants true, false, and null MUST be in lower case.
See Joomla Coding Standards: https://github.com/joomla/coding-standards/blob/master/manual/php.md
Testing Instructions
Code review
Documentation Changes Required
None