Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to use the global value for character count in newsfeeds #12869

Merged
merged 2 commits into from
Nov 16, 2016

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Nov 11, 2016

Summary of Changes

Removes the default value from the feed_character_count parameter in newsfeed form and menu item.
Adds the "Show Global Value" feature to those two fields
This allows to leave the field empty and thus use the value from the component configuration.

Testing Instructions

  1. Create a newsfeed
  2. Create a menu item for that newsfeed
  3. Play around with the "Characters Count" parameter and make sure it works as expected. If the field is empty, it should show a hint with the value from the component configuration.

Documentation Changes Required

None

@andrepereiradasilva
Copy link
Contributor

works on news feed edit and news feed menu item type, but not working properly in "List All News Feed Categories" and "List News Feeds in a Category" menu item types

@Bakual
Copy link
Contributor Author

Bakual commented Nov 12, 2016

I have no clue why I missed those two. Done now. 👍

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 622b55e

works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12869.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 622b55e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12869.

@andrepereiradasilva
Copy link
Contributor

RTC?

@brianteeman
Copy link
Contributor

I am sure tobias will do that when he gets online (I shouldnt do it as I was a tester - but i sometimes forget that rule)

@andrepereiradasilva
Copy link
Contributor

sure, just pinging in case someone forgot

@brianteeman
Copy link
Contributor

I know that @zero-24 and I both run the Two Tests check on the issue tracker multiple times a day - we dont need to be pinged unless its been a few days in which case we have missed it

@andrepereiradasilva
Copy link
Contributor

ok ok

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Nov 16, 2016
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Nov 16, 2016
@rdeutz rdeutz merged commit b47891f into joomla:staging Nov 16, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 16, 2016
@Bakual Bakual deleted the AddGlobalOptionNewsfeedCharCount branch November 16, 2016 19:35
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Nov 25, 2016
* staging: (98 commits)
  Coding style. PHP constants true, false, and null MUST be in lower case. (joomla#13010)
  Removing duplicated AS in sql query (joomla#13006)
  Fixed typo in comment (joomla#12992)
  Correcting strings in TFA Google plugin (joomla#12980)
  code style changes (joomla#12986)
  Error in sr-YU installation ini file (joomla#12984)
  New DateTime picker (replaces calendar) (joomla#11138)
  Export of Banners Tracks Does Not Export the Banner Name
  fix rues get data (joomla#12763)
  Added Feature items filter to mod_articles_news (joomla#12547)
  fix them all (joomla#12943)
  a11y regression fix (joomla#12935)
  Set correct component id for system links (joomla#12938)
  Fix for Undefined offset in Content History preview popup (joomla#12791)
  remove tab on meta charset (joomla#12895)
  JSession patched to set session _state to 'inactive' when session is closed. (joomla#12928)
  [JHtmlNumber::bytes] Format number according to language (joomla#12929)
  Update edit.php (joomla#12818)
  Update default.xml (joomla#12917)
  Adding the ability to use the global value for character count in newsfeeds (joomla#12869)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants