Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mod-menu] code style changes #12986

Merged
merged 1 commit into from
Nov 23, 2016
Merged

[mod-menu] code style changes #12986

merged 1 commit into from
Nov 23, 2016

Conversation

shur
Copy link
Contributor

@shur shur commented Nov 23, 2016

Summary of Changes

Code style changes for mod_menu layout.

Testing Instructions

Code review

@infograf768
Copy link
Member

Looks OK on review here.

@Bakual Bakual merged commit f94086d into joomla:staging Nov 23, 2016
@Bakual Bakual added this to the Joomla 3.7.0 milestone Nov 23, 2016
@shur
Copy link
Contributor Author

shur commented Nov 23, 2016 •
edited
Loading

what you think about if this code:

$id = '';

if ($tagId = $params->get('tag_id', ''))
{
	$id = ' id="' . $tagId . '"';
}

replace to:

$id = $params->get('tag_id', '');
$id = $id ? ' id="' . $id . '"' : '';

@Bakual
Copy link
Contributor

Bakual commented Nov 23, 2016

I'd leave the current one as it is more readable (imho).

roland-d added a commit to roland-d/joomla-cms that referenced this pull request Nov 25, 2016
@roland-d
Merge branch 'staging' into shareable-draft-content-feature
4823b55 
* staging: (98 commits)
  Coding style. PHP constants true, false, and null MUST be in lower case. (joomla#13010)
  Removing duplicated AS in sql query (joomla#13006)
  Fixed typo in comment (joomla#12992)
  Correcting strings in TFA Google plugin (joomla#12980)
  code style changes (joomla#12986)
  Error in sr-YU installation ini file (joomla#12984)
  New DateTime picker (replaces calendar) (joomla#11138)
  Export of Banners Tracks Does Not Export the Banner Name
  fix rues get data (joomla#12763)
  Added Feature items filter to mod_articles_news (joomla#12547)
  fix them all (joomla#12943)
  a11y regression fix (joomla#12935)
  Set correct component id for system links (joomla#12938)
  Fix for Undefined offset in Content History preview popup (joomla#12791)
  remove tab on meta charset (joomla#12895)
  JSession patched to set session _state to 'inactive' when session is closed. (joomla#12928)
  [JHtmlNumber::bytes] Format number according to language (joomla#12929)
  Update edit.php (joomla#12818)
  Update default.xml (joomla#12917)
  Adding the ability to use the global value for character count in newsfeeds (joomla#12869)
  ...
@shur shur deleted the patch-1 branch November 28, 2016 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Joomla 3.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@shur @infograf768 @Bakual @joomla-cms-bot