Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_search] Add useglobal to "Search Form or Search Results" menu item type #12917

Merged
merged 1 commit into from
Nov 17, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Nov 16, 2016

Summary of Changes

This adds useglobal to com_search also.

Notes:

  • Changed a default value from "0" to "newest" (there is no option "0" in that select...)

Testing Instructions

  1. Apply patch
  2. Go to com_search options and save them
  3. Create a menu item of "Search" > "Search Form or Search Results" type and check if the use global are correctly populated.

image

Documentation Changes Required

None.

@andrepereiradasilva andrepereiradasilva changed the title [com_search] Add useglobal to Search menu item type [com_search] Add useglobal to Search Form or Search Results menu item type Nov 16, 2016
@andrepereiradasilva andrepereiradasilva changed the title [com_search] Add useglobal to Search Form or Search Results menu item type [com_search] Add useglobal to "Search Form or Search Results" menu item type Nov 16, 2016
@brianteeman brianteeman changed the title [com_search] Add useglobal to "Search Form or Search Results" menu item type [com_search] Add useglobal to "Search Form or Search Results" menu item type Nov 16, 2016
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 12a2636


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12917.

1 similar comment
@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on 12a2636


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12917.

@zero-24 zero-24 added this to the Joomla 3.7.0 milestone Nov 17, 2016
@zero-24 zero-24 added the RTC This Pull Request is Ready To Commit label Nov 17, 2016
@rdeutz rdeutz merged commit dcbbc67 into joomla:staging Nov 17, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 17, 2016
roland-d added a commit to roland-d/joomla-cms that referenced this pull request Nov 25, 2016
* staging: (98 commits)
  Coding style. PHP constants true, false, and null MUST be in lower case. (joomla#13010)
  Removing duplicated AS in sql query (joomla#13006)
  Fixed typo in comment (joomla#12992)
  Correcting strings in TFA Google plugin (joomla#12980)
  code style changes (joomla#12986)
  Error in sr-YU installation ini file (joomla#12984)
  New DateTime picker (replaces calendar) (joomla#11138)
  Export of Banners Tracks Does Not Export the Banner Name
  fix rues get data (joomla#12763)
  Added Feature items filter to mod_articles_news (joomla#12547)
  fix them all (joomla#12943)
  a11y regression fix (joomla#12935)
  Set correct component id for system links (joomla#12938)
  Fix for Undefined offset in Content History preview popup (joomla#12791)
  remove tab on meta charset (joomla#12895)
  JSession patched to set session _state to 'inactive' when session is closed. (joomla#12928)
  [JHtmlNumber::bytes] Format number according to language (joomla#12929)
  Update edit.php (joomla#12818)
  Update default.xml (joomla#12917)
  Adding the ability to use the global value for character count in newsfeeds (joomla#12869)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants