Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manual cherrypick of #15168 #15346

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Manual cherrypick of #15168 #15346

merged 7 commits into from
Jun 28, 2024

Conversation

craigbox
Copy link
Contributor

Takes the changes to the Getting Started guide, as well as some follow-up PRs and related issues, to release-1.22.

Hopefully.

@craigbox craigbox requested review from a team as code owners June 26, 2024 10:44
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 26, 2024
@craigbox craigbox linked an issue Jun 26, 2024 that may be closed by this pull request
[release-1.22] docs: break apart the ambient getting start guide (WIP) #15332
Closed
@craigbox
Copy link
Contributor Author

@kfaseela are these test results OK - should an ambient profile test be enabled on release-1.22 ?

@kfaseela kfaseela mentioned this pull request Jun 27, 2024
Merged
@kfaseela
Copy link
Member

/retest

@kfaseela
Copy link
Member

@craigbox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
doc.test.profile-ambient_istio.io_release-1.22 b79c016 link false /test doc.test.profile-ambient

pattern /home/prow/go/src/istio.io/istio.io/tests/setup/profile-ambient/...: lstat /home/prow/go/src/istio.io/istio.io/tests/setup/profile-ambient/: no such file or directory

you need to cherrypick #15210 too

@kfaseela
Copy link
Member

@craigbox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
Test name Commit Details Required Rerun command
doc.test.profile-ambient_istio.io_release-1.22 b79c016 link false /test doc.test.profile-ambient

pattern /home/prow/go/src/istio.io/istio.io/tests/setup/profile-ambient/...: lstat /home/prow/go/src/istio.io/istio.io/tests/setup/profile-ambient/: no such file or directory

you need to cherrypick #15210 too

I just did it #15359

@kfaseela
Copy link
Member

/retest

@kfaseela
Copy link
Member

it would be better to wait for the wasm pr to be merged, and rebase this PR on top of that

peterj and others added 6 commits June 28, 2024 09:21
@peterj @craigbox @dhawton
docs: break apart the ambient getting start guide (WIP) (istio#15168)
18b9a5f 
* break apart the ambient getting start guide

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* fix linter issues

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* add tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* Craig's first edits

* lint fixes

* Fix tests

* fix tests

* test for istio#15200 workaround

* fix tests (thanks Faseela for helping me get them running locally!)

* Fix the snip generator?

* remove Wasm test because it depends on snips we're moving around

* rebase go.mod properly

* remove spelling

* new screenshots + pr fixes

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* can't test locally so let's hope

* lint fixes

* make gen & fix test

* fixy testy

* Fix snip

* fix tests as we learn more

* Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md

Co-authored-by: Daniel Hawton <daniel@hawton.org>

* fixing the wasm tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

---------

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Co-authored-by: Craig Box <craig.box@gmail.com>
Co-authored-by: Daniel Hawton <daniel@hawton.org>
@craigbox
cherrypick istio#15227 too
b74ee8b
@kfaseela @craigbox
move ambient tests to ambient profile (istio#15241)
8d6811c 
Signed-off-by: Faseela K <faseela.k@est.tech>
@craigbox
Manual cherry-pick the last of 15293
25bb509
@craigbox
Fix gencheck with release-1.22 versions of the tests
f166852
@craigbox
re-add setup snips to fix the tests again; there's no avoiding istio#…
b789a8d 
…15200
@craigbox
Copy link
Contributor Author

/retest

@craigbox
Copy link
Contributor Author

The ambient profile was added in istio/test-infra#5410.
We are now failing on needing a script that was fixed on master in istio/istio#51329.

Is there any way to resolve the test version to a commit on release-1.22 or do we have to wait for 1.22.3 for this to potentially pass?

@dhawton @kfaseela

kfaseela
kfaseela reviewed Jun 28, 2024
View reviewed changes
content/en/docs/ambient/getting-started/test.sh
samples/bookinfo/platform/kube/cleanup.sh
snip_uninstall_4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can add an explicit kubectl delete authorizationpolicies --all here as a workaround

@kfaseela
Copy link
Member

@craigbox all good now :)

craigbox
craigbox commented Jun 28, 2024
View reviewed changes
Copy link
Contributor Author

@craigbox craigbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @kfaseela !
Feel free to merge when you're ready

@istio-testing istio-testing merged commit f18fbf7 into istio:release-1.22 Jun 28, 2024
13 checks passed
@zirain zirain mentioned this pull request Jul 2, 2024
Closed
@craigbox craigbox deleted the cherrypick-15168 branch July 2, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfaseela kfaseela kfaseela approved these changes

Assignees
No one assigned
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[release-1.22] docs: break apart the ambient getting start guide (WIP)
4 participants
@craigbox @kfaseela @istio-testing @peterj