Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ambient tests to ambient profile #15241

Merged

Conversation

kfaseela
Copy link
Member

@kfaseela kfaseela commented Jun 4, 2024

Description

Now that we have ambient profile, so let us use that for the ambient tests.

Reviewers

  • Ambient
  • Docs
  • Installation
  • Networking
  • Performance and Scalability
  • Extensions and Telemetry
  • Security
  • Test and Release
  • User Experience
  • Developer Infrastructure
  • Localization/Translation

Signed-off-by: Faseela K <faseela.k@est.tech>
@kfaseela kfaseela requested a review from a team as a code owner June 4, 2024 18:40
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 4, 2024
@istio-testing istio-testing merged commit cf4143b into istio:master Jun 4, 2024
13 checks passed
wilsonwu added a commit to wilsonwu/istio.io that referenced this pull request Jun 5, 2024
@craigbox craigbox mentioned this pull request Jun 26, 2024
1 task
craigbox pushed a commit to craigbox/istio.io that referenced this pull request Jun 26, 2024
Signed-off-by: Faseela K <faseela.k@est.tech>
craigbox pushed a commit to craigbox/istio.io that referenced this pull request Jun 27, 2024
Signed-off-by: Faseela K <faseela.k@est.tech>
istio-testing pushed a commit that referenced this pull request Jun 28, 2024
* docs: break apart the ambient getting start guide (WIP) (#15168)

* break apart the ambient getting start guide

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* fix linter issues

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* add tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* Craig's first edits

* lint fixes

* Fix tests

* fix tests

* test for #15200 workaround

* fix tests (thanks Faseela for helping me get them running locally!)

* Fix the snip generator?

* remove Wasm test because it depends on snips we're moving around

* rebase go.mod properly

* remove spelling

* new screenshots + pr fixes

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* can't test locally so let's hope

* lint fixes

* make gen & fix test

* fixy testy

* Fix snip

* fix tests as we learn more

* Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md

Co-authored-by: Daniel Hawton <daniel@hawton.org>

* fixing the wasm tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

---------

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Co-authored-by: Craig Box <craig.box@gmail.com>
Co-authored-by: Daniel Hawton <daniel@hawton.org>

* cherrypick #15227 too

* move ambient tests to ambient profile (#15241)

Signed-off-by: Faseela K <faseela.k@est.tech>

* Manual cherry-pick the last of 15293

* Fix gencheck with release-1.22 versions of the tests

* re-add setup snips to fix the tests again; there's no avoiding #15200

* Update content/en/docs/ambient/getting-started/test.sh

---------

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Faseela K <faseela.k@est.tech>
Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com>
Co-authored-by: Daniel Hawton <daniel@hawton.org>
Co-authored-by: Faseela K <faseela.k@est.tech>
Co-authored-by: Faseela K <k.faseela@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants