Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test scripts break when a folder with snips is created and removed in the same PR #15200

Open
craigbox opened this issue May 30, 2024 · 0 comments
Open

test scripts break when a folder with snips is created and removed in the same PR #15200

craigbox opened this issue May 30, 2024 · 0 comments
Labels
area/test and release good first issue Indicates a good first issue for new contributors

Comments

@craigbox
Copy link
Contributor

In #15168 we created ambient/getting-started/setup/snips.sh, and it was removed in a later commit.

Now, tests won't pass, because scripts/pr_tests.pyis looking at all the places a snips.sh existed in all commits, not just in the end state.

+ echo 'Optimizing tests for pull number: 15168'
Optimizing tests for pull number: 15168
++ python3 ./scripts/pr_tests.py --token= 15168
+ TESTS=ambient/usage/extend-waypoint-wasm,ambient/getting-started/setup,ambient/getting-started/cleanup,ambient/getting-started/manage-traffic,ambient/getting-started/secure-and-visualize,ambient/getting-started/enforce-auth-policies,ambient/getting-started/deploy-sample-app,ambient/getting-started
@craigbox craigbox added area/test and release good first issue Indicates a good first issue for new contributors labels May 30, 2024
@craigbox craigbox mentioned this issue May 30, 2024
Merged
14 tasks
craigbox added a commit to peterj/istio.io that referenced this issue May 30, 2024
@craigbox
test for istio#15200 workaround
ac340ee
craigbox added a commit to peterj/istio.io that referenced this issue May 30, 2024
@craigbox
test for istio#15200 workaround
885b2c6
istio-testing pushed a commit that referenced this issue Jun 2, 2024
@peterj @craigbox @dhawton
docs: break apart the ambient getting start guide (WIP) (#15168)
8b3072f 
* break apart the ambient getting start guide

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* fix linter issues

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* add tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* Craig's first edits

* lint fixes

* Fix tests

* fix tests

* test for #15200 workaround

* fix tests (thanks Faseela for helping me get them running locally!)

* Fix the snip generator?

* remove Wasm test because it depends on snips we're moving around

* rebase go.mod properly

* remove spelling

* new screenshots + pr fixes

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* can't test locally so let's hope

* lint fixes

* make gen & fix test

* fixy testy

* Fix snip

* fix tests as we learn more

* Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md

Co-authored-by: Daniel Hawton <daniel@hawton.org>

* fixing the wasm tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

---------

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Co-authored-by: Craig Box <craig.box@gmail.com>
Co-authored-by: Daniel Hawton <daniel@hawton.org>
@craigbox craigbox mentioned this issue Jun 3, 2024
Merged
2 tasks
craigbox added a commit to craigbox/istio.io that referenced this issue Jun 26, 2024
@peterj @craigbox @dhawton
docs: break apart the ambient getting start guide (WIP) (istio#15168)
2334dd5 
* break apart the ambient getting start guide

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* fix linter issues

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* add tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* Craig's first edits

* lint fixes

* Fix tests

* fix tests

* test for istio#15200 workaround

* fix tests (thanks Faseela for helping me get them running locally!)

* Fix the snip generator?

* remove Wasm test because it depends on snips we're moving around

* rebase go.mod properly

* remove spelling

* new screenshots + pr fixes

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* can't test locally so let's hope

* lint fixes

* make gen & fix test

* fixy testy

* Fix snip

* fix tests as we learn more

* Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md

Co-authored-by: Daniel Hawton <daniel@hawton.org>

* fixing the wasm tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

---------

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Co-authored-by: Craig Box <craig.box@gmail.com>
Co-authored-by: Daniel Hawton <daniel@hawton.org>
craigbox added a commit to craigbox/istio.io that referenced this issue Jun 26, 2024
@craigbox
re-add setup snips to fix the tests again; there's no avoiding istio#…
b79c016 
…15200
craigbox added a commit to craigbox/istio.io that referenced this issue Jun 27, 2024
@peterj @craigbox @dhawton
docs: break apart the ambient getting start guide (WIP) (istio#15168)
18b9a5f 
* break apart the ambient getting start guide

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* fix linter issues

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* add tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* Craig's first edits

* lint fixes

* Fix tests

* fix tests

* test for istio#15200 workaround

* fix tests (thanks Faseela for helping me get them running locally!)

* Fix the snip generator?

* remove Wasm test because it depends on snips we're moving around

* rebase go.mod properly

* remove spelling

* new screenshots + pr fixes

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* can't test locally so let's hope

* lint fixes

* make gen & fix test

* fixy testy

* Fix snip

* fix tests as we learn more

* Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md

Co-authored-by: Daniel Hawton <daniel@hawton.org>

* fixing the wasm tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

---------

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Co-authored-by: Craig Box <craig.box@gmail.com>
Co-authored-by: Daniel Hawton <daniel@hawton.org>
craigbox added a commit to craigbox/istio.io that referenced this issue Jun 27, 2024
@craigbox
re-add setup snips to fix the tests again; there's no avoiding istio#…
b789a8d 
…15200
istio-testing pushed a commit that referenced this issue Jun 28, 2024
@craigbox @peterj
@dhawton @kfaseela
Manual cherrypick of #15168 (#15346)
f18fbf7 
* docs: break apart the ambient getting start guide (WIP) (#15168)

* break apart the ambient getting start guide

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* fix linter issues

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* wip

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* add tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* Craig's first edits

* lint fixes

* Fix tests

* fix tests

* test for #15200 workaround

* fix tests (thanks Faseela for helping me get them running locally!)

* Fix the snip generator?

* remove Wasm test because it depends on snips we're moving around

* rebase go.mod properly

* remove spelling

* new screenshots + pr fixes

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

* can't test locally so let's hope

* lint fixes

* make gen & fix test

* fixy testy

* Fix snip

* fix tests as we learn more

* Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md

Co-authored-by: Daniel Hawton <daniel@hawton.org>

* fixing the wasm tests

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>

---------

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Co-authored-by: Craig Box <craig.box@gmail.com>
Co-authored-by: Daniel Hawton <daniel@hawton.org>

* cherrypick #15227 too

* move ambient tests to ambient profile (#15241)

Signed-off-by: Faseela K <faseela.k@est.tech>

* Manual cherry-pick the last of 15293

* Fix gencheck with release-1.22 versions of the tests

* re-add setup snips to fix the tests again; there's no avoiding #15200

* Update content/en/docs/ambient/getting-started/test.sh

---------

Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
Signed-off-by: Faseela K <faseela.k@est.tech>
Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com>
Co-authored-by: Daniel Hawton <daniel@hawton.org>
Co-authored-by: Faseela K <faseela.k@est.tech>
Co-authored-by: Faseela K <k.faseela@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/test and release good first issue Indicates a good first issue for new contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@craigbox