Remove empty folder with snips #15227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/S
|
As suspected, all tests are failing:
and this will need force-merging. Tests won't fail after, they will only fail during. |
|
@craigbox: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
i did not get this error on #15226 |
|
The error is only caused in PRs that _remove_ a folder with snips.
The test scripts look at folders that were touched by any commit, and
contain a snips.sh file.
|
|
@howardjohn are you OK to force-merge this? |
howardjohn
approved these changes
Jun 3, 2024
craigbox
added a commit
to craigbox/istio.io
that referenced
this pull request
Jun 26, 2024
craigbox
added a commit
to craigbox/istio.io
that referenced
this pull request
Jun 27, 2024
istio-testing
pushed a commit
that referenced
this pull request
Jun 28, 2024
* docs: break apart the ambient getting start guide (WIP) (#15168) * break apart the ambient getting start guide Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * fix linter issues Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * wip Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * add tests Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * Craig's first edits * lint fixes * Fix tests * fix tests * test for #15200 workaround * fix tests (thanks Faseela for helping me get them running locally!) * Fix the snip generator? * remove Wasm test because it depends on snips we're moving around * rebase go.mod properly * remove spelling * new screenshots + pr fixes Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> * can't test locally so let's hope * lint fixes * make gen & fix test * fixy testy * Fix snip * fix tests as we learn more * Update content/en/docs/ambient/getting-started/secure-and-visualize/index.md Co-authored-by: Daniel Hawton <daniel@hawton.org> * fixing the wasm tests Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Co-authored-by: Craig Box <craig.box@gmail.com> Co-authored-by: Daniel Hawton <daniel@hawton.org> * cherrypick #15227 too * move ambient tests to ambient profile (#15241) Signed-off-by: Faseela K <faseela.k@est.tech> * Manual cherry-pick the last of 15293 * Fix gencheck with release-1.22 versions of the tests * re-add setup snips to fix the tests again; there's no avoiding #15200 * Update content/en/docs/ambient/getting-started/test.sh --------- Signed-off-by: Peter Jausovec <peter.jausovec@solo.io> Signed-off-by: Faseela K <faseela.k@est.tech> Co-authored-by: Peter Jausovec <peterj@users.noreply.github.com> Co-authored-by: Daniel Hawton <daniel@hawton.org> Co-authored-by: Faseela K <faseela.k@est.tech> Co-authored-by: Faseela K <k.faseela@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #15168 we had, once, created a folder with an index.md/
test: yes/snips.sh combo.It was removed in a later commit, but the script checked directories that had existed in any commit (#15200). Thus, this file needed to be created with a boilerplate (and otherwise empty) snips.sh to have the tests pass. It is now being removed.
Reviewers
If the tests pass, @kfaseela. If they do not, then I think it will need to be forced, and I summon @howardjohn assuming it's rude to ask Eric, and I'm not sure who else can do such things (Louis? MItch? Anyone on the TOC?)