-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 0.6.0 #192
Merged
Merged
Update to 0.6.0 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this is no longer needed to download the executables
add_stages_from_waterboards and add_bottom_height_from_waterboards
add hydrology as topic
And improve handling of columns
- get_structured_grid_ds: create a structured grid DataSet - get_vertex_grid_ds: create a vertex grid Dataset
- allow creation of datasets based on flopy modelgrid objects - supports both vertex and structured grid
- update RTD workflow - update CI workflow - remove setup.py - move shape data
fix #171 header reading is now fine if not all ascii keys: "ncols", "nrows", "nodata_value", "xllcorner", "yllcorner", "cellsize", "xllcenter", "yllcenter", are in the header
- add gridtype attr - improve reading grids at real-world coords - set delr/delc for structured grids
add correct x,y-offsets
depedencies for knmi_data_platform backend using hdf5 files are now optional
- get_heads_dataarray - get_heads_array
- create mfoutput.py with generic _get_output_da function - apply new function in - get_heads_da - get_conc_da - get_budget_da
- use map_array as base for animate_map
- support no colors by setting "none"
Several improvements from NH zoet/zout project
* Flip meteobase data and bug in loading data * Default to replacing nodata values with nan * Meteobase: Remove nodata value from attributes when converting nodata to nan * move flipping when interpreting y instead of reading ascii * formatting --------- Co-authored-by: Martin Vonk <vonk.mart@gmail.com> Bas des Tombe
* use xarray facet plot in nb * use xarray facet plot in nb
* improve data variable handling: - use _get_value_from_ds_attr and _get_value_from_data_var - deprecation warning for ghb/drn `da_name=` kwarg - rename 'chd' arg to 'mask' (with deprecationwarning) * move _get_value_from_ds_* funcs to util * move _get_value_from_ds_* funcs to util * rename "_peil" to "_stage" data var for rws data * line length * shorten func names - since we use ds as a common abbreviation for dataset * add tests for _get_value_from_ds_* * update notebooks * update tests * isort * fix import * codacy * Remove da_name from nlmod.gwf.ghb in transport-notebook --------- Co-authored-by: Ruben Caljé <r.calje@artesia-water.nl>
* add test for lake * add evaporation to test * update docstring * add extra test and some fixes to lake from_gdf * Add a TODO to check for a length unit --------- Co-authored-by: Ruben Caljé <r.calje@artesia-water.nl>
Lots of stuff here! Seems like this update might deserve more than a minor version bump? Perhaps 0.6.0? |
dbrakenhoff
reviewed
Jun 7, 2023
README.md
Outdated
If you are using nlmod for the first time you need to download the MODFLOW executables. You can easily download these executables by running this Python code: | ||
|
||
import nlmod | ||
import nlmod | ||
nlmod.util.download_mfbinaries() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function can be called from nlmod directly now.
dbrakenhoff
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.