Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several improvements from NH zoet/zout project #183

Merged
merged 20 commits into from
Jun 5, 2023
Merged

Several improvements from NH zoet/zout project #183

merged 20 commits into from
Jun 5, 2023

Conversation

dbrakenhoff
Copy link
Collaborator

@dbrakenhoff dbrakenhoff commented May 30, 2023 •
edited
Loading

Some changes I made while working on a project:

  • Improve creating DataSets from existing modflow models (d55865c)
  • Add "sum" and "first" methods to nlmod.resample.aggregate_values (18d7331)
  • Improve creating time index from several sources (flopy model, model.modeltime object, time array) (cf1aa30)
  • Improve groundwater flow/transport output (1860e7e, c6cdecc)
    • support for angrot
    • support for non-constant delr/delc
    • use new time index logic
    • use generic _get_output_da to reduce code duplication
  • improve well tools (b5f3728)
    • avoid adding wells to non-active layers
    • improve handling of aux variable
  • improve plotting (7d3d76d , ba11748, 06e524e)
  • some code cleanup (remove old head reading functions in util.py)
  • label layers without coloring in DatasetCrossSection
  • allow nlmod.download_mfbinaries for easy access

TODO:

  • improve groundwater transport output functionality (similar to what I did for groundwater flow above)
  • reduce duplication in flopy and nlmod plotting and animation methods (now I have to fix things in several places every time)
  • update list above

@dbrakenhoff
set x/y coordinates local for structured grid in case angrot!=0
d55865c
@dbrakenhoff
add "sum" and "first" methods to aggregate_values function
18d7331
@dbrakenhoff
add functions to obtain time index for xarray
cf1aa30 
- from model
- from model.modeltime
- from array of elapsed time
@dbrakenhoff
improve gwf output
1860e7e 
- build time index from output times
- add support for non constant delr/delc
- improve support for angrot
@dbrakenhoff
improve well tools
b5f3728 
- ensure no wells added in inactive cells
- improve handling of aux variable
@dbrakenhoff
improve flopy plotting
7d3d76d
@dbrakenhoff
improve dataset plotting
ba11748 
- add support for rotation argument
- add extent kwarg
- add date_fmt for plot title
- add alpha
@dbrakenhoff
black + isort
8b6f67e
@dbrakenhoff
accidentally removed return
d4691ec
@dbrakenhoff dbrakenhoff self-assigned this May 30, 2023
@dbrakenhoff dbrakenhoff marked this pull request as draft May 30, 2023 14:08
@dbrakenhoff
remove deprecated functions
4e1b474 
- get_heads_dataarray
- get_heads_array
@dbrakenhoff
refactor gwf/gwt output
c6cdecc 
- create mfoutput.py with generic _get_output_da function
- apply new function in
  - get_heads_da
  - get_conc_da
  - get_budget_da
@dbrakenhoff
improve plotting
06e524e 
- use map_array as base for animate_map
@dbrakenhoff
add download_mfbinaries to nlmod root
4a2d4d1
@dbrakenhoff
improve DatasetCrossSection
fbc611b 
- support no colors by setting "none"
@dbrakenhoff dbrakenhoff marked this pull request as ready for review June 2, 2023 14:35
@OnnoEbbens OnnoEbbens merged commit 6be8251 into dev Jun 5, 2023
@OnnoEbbens OnnoEbbens deleted the nhzz branch July 12, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OnnoEbbens OnnoEbbens Awaiting requested review from OnnoEbbens

Assignees

@dbrakenhoff dbrakenhoff

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dbrakenhoff @OnnoEbbens