Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for lake #184

Merged
merged 6 commits into from
Jun 7, 2023
Merged

add test for lake #184

merged 6 commits into from
Jun 7, 2023

Conversation

OnnoEbbens
Copy link
Collaborator

Added a test for the lake package. The test covers a simple case with 2 lakes, evaporation and one like overflowing in the other.

@OnnoEbbens OnnoEbbens requested a review from bdestombe June 1, 2023 14:49
@bdestombe
Copy link
Collaborator

Great worrk Onno!

Similarly to time_conversion, we should check the length unit is meters to deal with the dimension specific constants of Manning's eq. length_conversion should be fixed to 1 as we model in meters.

The manual says the following:

to 3.28081, 1.0, and 100.0 when using length units (LENGTH UNITS) of feet, meters, 
or centime�ters in the simulation, respectively. LENGTH CONVERSION does not 
need to be specified if no lake outlets are specified or LENGTH UNITS are meters.

Other than that, looks good to me!

@rubencalje
Copy link
Collaborator

Great worrk Onno!

Similarly to time_conversion, we should check the length unit is meters to deal with the dimension specific constants of Manning's eq. length_conversion should be fixed to 1 as we model in meters.

The manual says the following:

to 3.28081, 1.0, and 100.0 when using length units (LENGTH UNITS) of feet, meters, 
or centime�ters in the simulation, respectively. LENGTH CONVERSION does not 
need to be specified if no lake outlets are specified or LENGTH UNITS are meters.

Other than that, looks good to me!

Good remark. We do not add a length unit to ds right now, so I added a todo-comment, so we can merge this Pull Request now.

@rubencalje rubencalje merged commit 68db768 into dev Jun 7, 2023
@rubencalje rubencalje deleted the lake_tests branch June 20, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants