-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flip MeteoBase data #185
Flip MeteoBase data #185
Conversation
Hi @bdestombe, Thanks for the PR. Can you tell me which bug this solves? And why the data has to be flipped? Also, on the nodata default argument; the |
Hi Martin, Nans were invented exactly for this purpose, so why not use them? The nodata value is used when working with integers. And some file formats require working with integers such that nodata values are inherently required. That is not the case here, as all the products contain floats and xarray manages nans quite well. When exported to tiffs the nans get correctly propagated otherwise you'd manually have to assign the no data value via rioxarray. Furthermore, the xarray plotting utilities work well with nans. But you are right, the nodata_value now has no further meaning. I'll remove it in the PR. Thanks for your feedback! |
Is this also the case with the other products? Or is this a problem with MeteoBase? |
I'm fine with using NaNs, as long as the metadata stays consistent :) So the current solution is fine with me. |
Good question.. I am not sure how to check this. Any suggestions? |
Both evapotranspiration and verdampingstekort are now orientated correctly. I'm not sure how to check precepitation. And Manning en Penman only contain nodata values on the dataset that I have at hand. |
We could maybe compare the precipitation dataset to the KNMI radar dataset (#166). See how that one compares to the flipped version. The dataset for meteobase does not contain NODATA for the Makkink and Penman evaporation: https://github.com/ArtesiaWater/nlmod/blob/main/tests/data/Meteobase_ASCII_test.zip |
Ah indeed! It shows data, but its too small with too little resolution to distinguish features. The produced geotiffs of your test data are attached. |
2ccc478
to
efc4055
Compare
I think it is fine now so we can merge this. I wasn't able to confirm the precipitation dataset with the KNMI data. KNMI uses another stereographic projection and I don't have time for that at the moment. |
No description provided.