Reading data from KNMI Data Platform #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add two type hints and move some arguments
needed for reading knmi_data_platform files
- also reformats the read_dataset_from_zip - add a function to read_nc_knmi
fix some handling with ZipFile
only open h5file when reading contents, also fix bug with getting h5Dataset
add check_hour function that handles hour=24
remove reading from download function
some renaming
remove _knmi from function names read dataset now also supports a list of fnames
martinvonk
force-pushed
the
knmi_data_platform
branch
from
2cb4c14
to
b74d51d
Compare
fix download_files function
martinvonk
force-pushed
the
knmi_data_platform
branch
from
97c1a71
to
dfd8e8d
Compare
file reading took too long
- add timeout to request.get
- better exceptions
- add docstring
- {} instead of dict()?
- nog wat ander gejank
martinvonk
force-pushed
the
knmi_data_platform
branch
from
abaa491
to
caaa084
Compare
rubencalje
approved these changes
May 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://dataplatform.knmi.nl/