Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serial no status #38391

Merged

Conversation

rohitwaghchaure
Copy link
Collaborator

Serial No showing status as "Inactive"

After Fix

Serial No showing status as "Delivered"

Screenshot 2023-11-28 at 4 21 09 PM

Added button "View Ledgers" in the Serial No to see the transactions created against the respective serial no. On click "View Ledgers" button system will open the Serial No Ledger report (see below image)

Screenshot 2023-11-28 at 4 19 58 PM

Fixed #38328

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #38391 (43304a5) into develop (d9b3b95) will decrease coverage by 0.01%.
Report is 10 commits behind head on develop.
The diff coverage is 82.35%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38391      +/-   ##
===========================================
- Coverage    67.23%   67.23%   -0.01%     
===========================================
  Files          758      758              
  Lines        60612    60624      +12     
===========================================
+ Hits         40755    40759       +4     
- Misses       19857    19865       +8     
Files Coverage Δ
erpnext/controllers/accounts_controller.py 84.96% <100.00%> (+0.11%) ⬆️
erpnext/stock/serial_batch_bundle.py 87.57% <100.00%> (+0.07%) ⬆️
.../stock/report/serial_no_ledger/serial_no_ledger.py 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 592fc81 into frappe:develop Nov 28, 2023
14 checks passed
mergify bot pushed a commit that referenced this pull request Nov 28, 2023
(cherry picked from commit 592fc81)
rohitwaghchaure added a commit that referenced this pull request Nov 28, 2023
fix: serial no status (#38391)

(cherry picked from commit 592fc81)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Nov 28, 2023
# [15.4.0](v15.3.0...v15.4.0) (2023-11-28)

### Bug Fixes

* allow on submit for child table fields ([ac7615a](ac7615a))
* annual income and expenses in digest ([ca2ad17](ca2ad17))
* check reposting settings before allowing editable si ([25bf475](25bf475))
* condition in other bundle utils ([e4d9ef1](e4d9ef1))
* create contact if existing customer doesn't have contact ([b1b065d](b1b065d))
* display all item rate stop messages (backport [#38289](#38289)) ([#38307](#38307)) ([99c1fbf](99c1fbf))
* do not set repost flag without validating voucher ([6a3c3b4](6a3c3b4))
* don't depreciate assets with no schedule on scrapping (backport [#38276](#38276)) ([#38293](#38293)) ([18613c5](18613c5))
* filter bundle items based on disabled check ([fb517e8](fb517e8))
* fiscal year using future date ([b9a1fac](b9a1fac))
* has_product_bundle util to only check for enabled bundles ([5c12872](5c12872))
* job card overlap validation (backport [#38345](#38345)) ([#38348](#38348)) ([d6fe7eb](d6fe7eb))
* make parameters of `create_subscription_process` optional (and other minor fixes) ([#38360](#38360)) ([721b429](721b429))
* Negative Qty and Rates in SO/PO (backport [#38252](#38252)) ([#38357](#38357)) ([14174df](14174df))
* no fstring in translation (backport [#38381](#38381)) ([#38387](#38387)) ([c101855](c101855))
* patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38264](#38264)) ([4c9890a](4c9890a))
* Payment Reco Issue and chart of account importer ([4699887](4699887))
* serial no status (backport [#38391](#38391)) ([#38397](#38397)) ([b65c225](b65c225))
* Server Error while creating Product Bundle (backport [#38377](#38377)) ([#38380](#38380)) ([922aef6](922aef6))
* skip disabled bundles for non-report utils ([3d46b32](3d46b32))
* skip fixed assets in parent ([314a91a](314a91a))
* Supplier `Primary Contact` (backport [#38268](#38268)) ([#38286](#38286)) ([37d1f1a](37d1f1a))
* **ux:** Sales Order Stock Reservation Dialog (backport [#38261](#38261)) ([#38344](#38344)) ([3cbe599](3cbe599))
* validation for existing bundles ([c0de9c0](c0de9c0))

### Features

* add Bank Transaction to connections in Journal and Payment Entry (backport [#38297](#38297)) ([#38301](#38301)) ([72647b8](72647b8))
* add disabled field in product bundle ([fcd53be](fcd53be))
* new Report "Lost Quotations" ([#38309](#38309)) ([ea2c348](ea2c348))

### Performance Improvements

* optimize total_purchase_cost update ([deed9f5](deed9f5))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The serial number function is abnormal。
1 participant