Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patch - Duplicate entry quality inspection parameter #38262

Conversation

rohitwaghchaure
Copy link
Collaborator

@rohitwaghchaure rohitwaghchaure commented Nov 22, 2023

convert_qi_parameter_to_link_field Patch failing

File "/home/frappe/frappe-bench/apps/erpnext/erpnext/patches/v13_0/convert_qi_parameter_to_link_field.py", line 26, in execute
    ).insert(ignore_permissions=True)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 278, in insert
    raise e
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 275, in insert
    self.db_insert()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/base_document.py", line 436, in db_insert
    raise frappe.DuplicateEntryError(self.doctype, self.name, e)
frappe.exceptions.DuplicateEntryError: ('Quality Inspection Parameter', 'Dimension 3: PCB side height', IntegrityError(1062, "Duplicate entry 'Dimension 3: PCB side height' for key 'PRIMARY'"))

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Nov 22, 2023
@rohitwaghchaure rohitwaghchaure force-pushed the fixed-patch-convert-qi-parameter-to-link-field branch from b4d3828 to 314d89e Compare November 22, 2023 07:49
Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Merging #38262 (314d89e) into develop (7db1127) will increase coverage by 0.01%.
Report is 63 commits behind head on develop.
The diff coverage is 84.61%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #38262      +/-   ##
===========================================
+ Coverage    67.26%   67.27%   +0.01%     
===========================================
  Files          757      757              
  Lines        60487    60515      +28     
===========================================
+ Hits         40684    40710      +26     
- Misses       19803    19805       +2     
Files Coverage Δ
...xt/accounts/doctype/payment_entry/payment_entry.py 83.66% <100.00%> (+0.05%) ⬆️
...t/manufacturing/doctype/bom_creator/bom_creator.py 80.18% <100.00%> (ø)
erpnext/selling/doctype/sales_order/sales_order.py 79.00% <50.00%> (ø)
erpnext/utilities/bulk_transaction.py 0.00% <0.00%> (ø)

... and 17 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 0ca7527 into frappe:develop Nov 22, 2023
13 checks passed
mergify bot pushed a commit that referenced this pull request Nov 22, 2023
mergify bot pushed a commit that referenced this pull request Nov 22, 2023
mergify bot pushed a commit that referenced this pull request Nov 22, 2023
rohitwaghchaure added a commit that referenced this pull request Nov 22, 2023
…38262) (#38265)

fix: patch - Duplicate entry quality inspection parameter (#38262)

(cherry picked from commit 0ca7527)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
mergify bot added a commit that referenced this pull request Nov 22, 2023
…38262) (#38265)

fix: patch - Duplicate entry quality inspection parameter (#38262)

(cherry picked from commit 0ca7527)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
(cherry picked from commit 095d99d)
rohitwaghchaure pushed a commit that referenced this pull request Nov 22, 2023
…38262) (backport #38265) (#38266)

fix: patch - Duplicate entry quality inspection parameter (backport #38262) (#38265)

fix: patch - Duplicate entry quality inspection parameter (#38262)

(cherry picked from commit 0ca7527)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
(cherry picked from commit 095d99d)

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
frappe-pr-bot pushed a commit that referenced this pull request Nov 22, 2023
## [13.54.13](v13.54.12...v13.54.13) (2023-11-22)

### Bug Fixes

* patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) (backport [#38265](#38265)) ([#38266](#38266)) ([b28e29c](b28e29c))
rohitwaghchaure added a commit that referenced this pull request Nov 23, 2023
…38262) (#38263)

fix: patch - Duplicate entry quality inspection parameter (#38262)

(cherry picked from commit 0ca7527)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
rohitwaghchaure added a commit that referenced this pull request Nov 23, 2023
…38262) (#38264)

fix: patch - Duplicate entry quality inspection parameter (#38262)

(cherry picked from commit 0ca7527)

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
frappe-pr-bot pushed a commit that referenced this pull request Nov 24, 2023
# [14.50.0](v14.49.0...v14.50.0) (2023-11-24)

### Bug Fixes

* don't depreciate non-depreciable assets on scrapping [v14] ([#38294](#38294)) ([5261aba](5261aba))
* partial cancel of gle and ple (backport [#35609](#35609)) ([80bc235](80bc235))
* patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38263](#38263)) ([756f08b](756f08b))
* Supplier `Primary Contact` (backport [#38268](#38268)) ([#38285](#38285)) ([f170cb9](f170cb9))

### Features

* add Bank Transaction to connections in Journal and Payment Entry ([#38297](#38297)) ([06c6da5](06c6da5))

### Performance Improvements

* optimize total_purchase_cost update ([a88d322](a88d322))
frappe-pr-bot pushed a commit that referenced this pull request Nov 28, 2023
# [15.4.0](v15.3.0...v15.4.0) (2023-11-28)

### Bug Fixes

* allow on submit for child table fields ([ac7615a](ac7615a))
* annual income and expenses in digest ([ca2ad17](ca2ad17))
* check reposting settings before allowing editable si ([25bf475](25bf475))
* condition in other bundle utils ([e4d9ef1](e4d9ef1))
* create contact if existing customer doesn't have contact ([b1b065d](b1b065d))
* display all item rate stop messages (backport [#38289](#38289)) ([#38307](#38307)) ([99c1fbf](99c1fbf))
* do not set repost flag without validating voucher ([6a3c3b4](6a3c3b4))
* don't depreciate assets with no schedule on scrapping (backport [#38276](#38276)) ([#38293](#38293)) ([18613c5](18613c5))
* filter bundle items based on disabled check ([fb517e8](fb517e8))
* fiscal year using future date ([b9a1fac](b9a1fac))
* has_product_bundle util to only check for enabled bundles ([5c12872](5c12872))
* job card overlap validation (backport [#38345](#38345)) ([#38348](#38348)) ([d6fe7eb](d6fe7eb))
* make parameters of `create_subscription_process` optional (and other minor fixes) ([#38360](#38360)) ([721b429](721b429))
* Negative Qty and Rates in SO/PO (backport [#38252](#38252)) ([#38357](#38357)) ([14174df](14174df))
* no fstring in translation (backport [#38381](#38381)) ([#38387](#38387)) ([c101855](c101855))
* patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38264](#38264)) ([4c9890a](4c9890a))
* Payment Reco Issue and chart of account importer ([4699887](4699887))
* serial no status (backport [#38391](#38391)) ([#38397](#38397)) ([b65c225](b65c225))
* Server Error while creating Product Bundle (backport [#38377](#38377)) ([#38380](#38380)) ([922aef6](922aef6))
* skip disabled bundles for non-report utils ([3d46b32](3d46b32))
* skip fixed assets in parent ([314a91a](314a91a))
* Supplier `Primary Contact` (backport [#38268](#38268)) ([#38286](#38286)) ([37d1f1a](37d1f1a))
* **ux:** Sales Order Stock Reservation Dialog (backport [#38261](#38261)) ([#38344](#38344)) ([3cbe599](3cbe599))
* validation for existing bundles ([c0de9c0](c0de9c0))

### Features

* add Bank Transaction to connections in Journal and Payment Entry (backport [#38297](#38297)) ([#38301](#38301)) ([72647b8](72647b8))
* add disabled field in product bundle ([fcd53be](fcd53be))
* new Report "Lost Quotations" ([#38309](#38309)) ([ea2c348](ea2c348))

### Performance Improvements

* optimize total_purchase_cost update ([deed9f5](deed9f5))
frappe-pr-bot pushed a commit that referenced this pull request Nov 29, 2023
## [13.54.14](v13.54.13...v13.54.14) (2023-11-29)

### Bug Fixes

* patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38265](#38265)) ([095d99d](095d99d))
* precision for invoice outstandings ([#38323](#38323)) ([190f77a](190f77a))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant