fix: Negative Qty and Rates in SO/PO #38252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marination
requested review from
deepeshgarg007,
rohitwaghchaure and
s-aga-r
as code owners
bosue
reviewed
Nov 21, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #38252 +/- ##
===========================================
+ Coverage 67.26% 67.27% +0.01%
===========================================
Files 757 757
Lines 60505 60580 +75
===========================================
+ Hits 40700 40757 +57
- Misses 19805 19823 +18
|
marination
commented
Nov 22, 2023
marination
changed the title
marination
force-pushed
the
negative-qty-develop
branch
from
10359d6
to
7c064f0
Compare
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2023
* fix: Don't allow negative qty in SO/PO * fix: Type casting for safe comparisons * fix: Grammar in error message * fix: Negative rates should be allowed via Update Items in SO/PO * fix: Use `non_negative` property in docfield & emove code validation (cherry picked from commit b9f5a1c)
rohitwaghchaure
pushed a commit
that referenced
this pull request
Nov 27, 2023
fix: Negative Qty and Rates in SO/PO (#38252) * fix: Don't allow negative qty in SO/PO * fix: Type casting for safe comparisons * fix: Grammar in error message * fix: Negative rates should be allowed via Update Items in SO/PO * fix: Use `non_negative` property in docfield & emove code validation (cherry picked from commit b9f5a1c) Co-authored-by: Marica <maricadsouza221197@gmail.com>
frappe-pr-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
# [15.4.0](v15.3.0...v15.4.0) (2023-11-28) ### Bug Fixes * allow on submit for child table fields ([ac7615a](ac7615a)) * annual income and expenses in digest ([ca2ad17](ca2ad17)) * check reposting settings before allowing editable si ([25bf475](25bf475)) * condition in other bundle utils ([e4d9ef1](e4d9ef1)) * create contact if existing customer doesn't have contact ([b1b065d](b1b065d)) * display all item rate stop messages (backport [#38289](#38289)) ([#38307](#38307)) ([99c1fbf](99c1fbf)) * do not set repost flag without validating voucher ([6a3c3b4](6a3c3b4)) * don't depreciate assets with no schedule on scrapping (backport [#38276](#38276)) ([#38293](#38293)) ([18613c5](18613c5)) * filter bundle items based on disabled check ([fb517e8](fb517e8)) * fiscal year using future date ([b9a1fac](b9a1fac)) * has_product_bundle util to only check for enabled bundles ([5c12872](5c12872)) * job card overlap validation (backport [#38345](#38345)) ([#38348](#38348)) ([d6fe7eb](d6fe7eb)) * make parameters of `create_subscription_process` optional (and other minor fixes) ([#38360](#38360)) ([721b429](721b429)) * Negative Qty and Rates in SO/PO (backport [#38252](#38252)) ([#38357](#38357)) ([14174df](14174df)) * no fstring in translation (backport [#38381](#38381)) ([#38387](#38387)) ([c101855](c101855)) * patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38264](#38264)) ([4c9890a](4c9890a)) * Payment Reco Issue and chart of account importer ([4699887](4699887)) * serial no status (backport [#38391](#38391)) ([#38397](#38397)) ([b65c225](b65c225)) * Server Error while creating Product Bundle (backport [#38377](#38377)) ([#38380](#38380)) ([922aef6](922aef6)) * skip disabled bundles for non-report utils ([3d46b32](3d46b32)) * skip fixed assets in parent ([314a91a](314a91a)) * Supplier `Primary Contact` (backport [#38268](#38268)) ([#38286](#38286)) ([37d1f1a](37d1f1a)) * **ux:** Sales Order Stock Reservation Dialog (backport [#38261](#38261)) ([#38344](#38344)) ([3cbe599](3cbe599)) * validation for existing bundles ([c0de9c0](c0de9c0)) ### Features * add Bank Transaction to connections in Journal and Payment Entry (backport [#38297](#38297)) ([#38301](#38301)) ([72647b8](72647b8)) * add disabled field in product bundle ([fcd53be](fcd53be)) * new Report "Lost Quotations" ([#38309](#38309)) ([ea2c348](ea2c348)) ### Performance Improvements * optimize total_purchase_cost update ([deed9f5](deed9f5))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
This is allowed in Sales and Purchase Orders
The same isn't allowed via Update Items
Similarly negative rates aren't allowed via Update Items either
Fix: