Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Bank Transaction to connections in Journal and Payment Entry #38297

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

barredterra
Copy link
Collaborator

@barredterra barredterra commented Nov 23, 2023

This makes it easier to check if we have reconciled a payment voucher with a Bank Transaction.

no-docs

@barredterra barredterra changed the title bt connection feat: add Bank Transaction to connections in Journal and Payment Entry Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Merging #38297 (895e638) into develop (627165d) will increase coverage by 0.00%.
Report is 9 commits behind head on develop.
The diff coverage is 68.96%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #38297   +/-   ##
========================================
  Coverage    67.26%   67.27%           
========================================
  Files          757      757           
  Lines        60517    60546   +29     
========================================
+ Hits         40709    40730   +21     
- Misses       19808    19816    +8     
Files Coverage Δ
erpnext/accounts/utils.py 73.33% <100.00%> (+0.16%) ⬆️
erpnext/assets/doctype/asset/depreciation.py 83.28% <50.00%> (-0.41%) ⬇️
...e/payment_reconciliation/payment_reconciliation.py 91.94% <65.00%> (-1.94%) ⬇️

... and 1 file with indirect coverage changes

@barredterra barredterra merged commit 3be345e into frappe:develop Nov 23, 2023
16 of 18 checks passed
@barredterra barredterra deleted the bt-connection branch November 23, 2023 13:02
mergify bot pushed a commit that referenced this pull request Nov 23, 2023
#38297)

* feat(Payment Entry): Bank Transaction connection

* feat(Journal Entry): Bank Transaction connection

(cherry picked from commit 3be345e)

# Conflicts:
#	erpnext/accounts/doctype/payment_entry/payment_entry.json
mergify bot pushed a commit that referenced this pull request Nov 23, 2023
#38297)

* feat(Payment Entry): Bank Transaction connection

* feat(Journal Entry): Bank Transaction connection

(cherry picked from commit 3be345e)
barredterra added a commit that referenced this pull request Nov 23, 2023
…y (backport #38297) (#38301)

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
deepeshgarg007 added a commit that referenced this pull request Nov 24, 2023
…-38297

feat: add Bank Transaction to connections in Journal and Payment Entry (#38297)
frappe-pr-bot pushed a commit that referenced this pull request Nov 24, 2023
# [14.50.0](v14.49.0...v14.50.0) (2023-11-24)

### Bug Fixes

* don't depreciate non-depreciable assets on scrapping [v14] ([#38294](#38294)) ([5261aba](5261aba))
* partial cancel of gle and ple (backport [#35609](#35609)) ([80bc235](80bc235))
* patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38263](#38263)) ([756f08b](756f08b))
* Supplier `Primary Contact` (backport [#38268](#38268)) ([#38285](#38285)) ([f170cb9](f170cb9))

### Features

* add Bank Transaction to connections in Journal and Payment Entry ([#38297](#38297)) ([06c6da5](06c6da5))

### Performance Improvements

* optimize total_purchase_cost update ([a88d322](a88d322))
frappe-pr-bot pushed a commit that referenced this pull request Nov 28, 2023
# [15.4.0](v15.3.0...v15.4.0) (2023-11-28)

### Bug Fixes

* allow on submit for child table fields ([ac7615a](ac7615a))
* annual income and expenses in digest ([ca2ad17](ca2ad17))
* check reposting settings before allowing editable si ([25bf475](25bf475))
* condition in other bundle utils ([e4d9ef1](e4d9ef1))
* create contact if existing customer doesn't have contact ([b1b065d](b1b065d))
* display all item rate stop messages (backport [#38289](#38289)) ([#38307](#38307)) ([99c1fbf](99c1fbf))
* do not set repost flag without validating voucher ([6a3c3b4](6a3c3b4))
* don't depreciate assets with no schedule on scrapping (backport [#38276](#38276)) ([#38293](#38293)) ([18613c5](18613c5))
* filter bundle items based on disabled check ([fb517e8](fb517e8))
* fiscal year using future date ([b9a1fac](b9a1fac))
* has_product_bundle util to only check for enabled bundles ([5c12872](5c12872))
* job card overlap validation (backport [#38345](#38345)) ([#38348](#38348)) ([d6fe7eb](d6fe7eb))
* make parameters of `create_subscription_process` optional (and other minor fixes) ([#38360](#38360)) ([721b429](721b429))
* Negative Qty and Rates in SO/PO (backport [#38252](#38252)) ([#38357](#38357)) ([14174df](14174df))
* no fstring in translation (backport [#38381](#38381)) ([#38387](#38387)) ([c101855](c101855))
* patch - Duplicate entry quality inspection parameter (backport [#38262](#38262)) ([#38264](#38264)) ([4c9890a](4c9890a))
* Payment Reco Issue and chart of account importer ([4699887](4699887))
* serial no status (backport [#38391](#38391)) ([#38397](#38397)) ([b65c225](b65c225))
* Server Error while creating Product Bundle (backport [#38377](#38377)) ([#38380](#38380)) ([922aef6](922aef6))
* skip disabled bundles for non-report utils ([3d46b32](3d46b32))
* skip fixed assets in parent ([314a91a](314a91a))
* Supplier `Primary Contact` (backport [#38268](#38268)) ([#38286](#38286)) ([37d1f1a](37d1f1a))
* **ux:** Sales Order Stock Reservation Dialog (backport [#38261](#38261)) ([#38344](#38344)) ([3cbe599](3cbe599))
* validation for existing bundles ([c0de9c0](c0de9c0))

### Features

* add Bank Transaction to connections in Journal and Payment Entry (backport [#38297](#38297)) ([#38301](#38301)) ([72647b8](72647b8))
* add disabled field in product bundle ([fcd53be](fcd53be))
* new Report "Lost Quotations" ([#38309](#38309)) ([ea2c348](ea2c348))

### Performance Improvements

* optimize total_purchase_cost update ([deed9f5](deed9f5))
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant