Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save NavMesh python bindings #619

Merged
merged 2 commits into from
May 6, 2020
Merged

Save NavMesh python bindings #619

merged 2 commits into from
May 6, 2020

Conversation

aclegg3
Copy link
Contributor

@aclegg3 aclegg3 commented May 5, 2020

Motivation and Context

Users may want to recompute the NavMesh and then cache it to disk in python for large scenes or high-resolution NavMeshes.

How Has This Been Tested

Local testing.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have completed my CLA (see CONTRIBUTING)
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aclegg3 aclegg3 requested a review from erikwijmans May 5, 2020 01:17
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label May 5, 2020
@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #619 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
- Coverage   58.26%   58.24%   -0.02%     
==========================================
  Files         130      130              
  Lines        5889     5889              
  Branches       84       84              
==========================================
- Hits         3431     3430       -1     
- Misses       2458     2459       +1     
Flag Coverage Δ
#CPP 54.23% <ø> (-0.04%) ⬇️
#JavaScript 10.00% <ø> (ø)
#Python 76.33% <ø> (ø)
Impacted Files Coverage Δ
src/esp/nav/PathFinder.cpp 83.27% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc6f89...1ad0fbd. Read the comment docs.

@aclegg3 aclegg3 merged commit 7753339 into master May 6, 2020
@aclegg3 aclegg3 deleted the save-navmesh-bindings branch May 6, 2020 19:20
dhruvbatra pushed a commit that referenced this pull request May 13, 2020
* master:
  Interactive RigidObject python tutorial page (#611)
  Update README.md
  Separate Scene And Object functionality into different classes (#628)
  Updated m.css submodule. (#627)
  Update agent state set state to be less confusing (#614)
  Direct Navmesh/Meshdata handling; PluginManager instance variable (#623)
  Documentation generator updates (#624)
  Update corrade submodule. (#618)
  Physics primitives (non-colliding) (#622)
  save_nav_mesh python bindings (#619)
  --Renamed GltfMeshData -> GenericMeshData; (#617)
  Update README.md
  Update README.md
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
Ram81 pushed a commit to Ram81/habitat-web-sim that referenced this pull request Dec 10, 2020
* master:
  Interactive RigidObject python tutorial page (facebookresearch#611)
  Update README.md
  Separate Scene And Object functionality into different classes (facebookresearch#628)
  Updated m.css submodule. (facebookresearch#627)
  Update agent state set state to be less confusing (facebookresearch#614)
  Direct Navmesh/Meshdata handling; PluginManager instance variable (facebookresearch#623)
  Documentation generator updates (facebookresearch#624)
  Update corrade submodule. (facebookresearch#618)
  Physics primitives (non-colliding) (facebookresearch#622)
  save_nav_mesh python bindings (facebookresearch#619)
  --Renamed GltfMeshData -> GenericMeshData; (facebookresearch#617)
  Update README.md
  Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants