-
Notifications
You must be signed in to change notification settings - Fork 419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive RigidObject python tutorial page #611
Conversation
Codecov Report
@@ Coverage Diff @@
## master #611 +/- ##
==========================================
+ Coverage 57.76% 58.69% +0.93%
==========================================
Files 135 136 +1
Lines 5974 6162 +188
Branches 84 84
==========================================
+ Hits 3451 3617 +166
- Misses 2523 2545 +22
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. Should be really helpful for folks.
Edit: Nvm. For some reason, bindings weren't being built. Clean build fixed it. dbatra at dbatra-mbp in ~/projects/habitat-sim/docs on rigid-object-tutorial
$ ./build-public.sh
...
...
Traceback (most recent call last):
File "./m.css/documentation/python.py", line 2636, in <module>
module = SourceFileLoader(name, args.conf).load_module()
File "<frozen importlib._bootstrap_external>", line 399, in _check_name_wrapper
File "<frozen importlib._bootstrap_external>", line 823, in load_module
File "<frozen importlib._bootstrap_external>", line 682, in load_module
File "<frozen importlib._bootstrap>", line 265, in _load_module_shim
File "<frozen importlib._bootstrap>", line 684, in _load
File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 678, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "conf-public.py", line 9, in <module>
from conf import *
File "/Users/dbatra/projects/habitat-sim/docs/conf.py", line 17, in <module>
import habitat_sim # NOQA
File "/Users/dbatra/projects/habitat-sim/docs/../habitat_sim/__init__.py", line 16, in <module>
from habitat_sim.simulator import *
File "/Users/dbatra/projects/habitat-sim/docs/../habitat_sim/simulator.py", line 21, in <module>
from habitat_sim.physics import MotionType
File "/Users/dbatra/projects/habitat-sim/docs/../habitat_sim/physics.py", line 5, in <module>
from habitat_sim._ext.habitat_sim_bindings import MotionType, VelocityControl
ImportError: cannot import name 'VelocityControl' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great overall! Kudos! Will be quite valuable to our users.
@@ -298,6 +298,9 @@ jobs: | |||
wget http://dl.fbaipublicfiles.com/habitat/objects_v0.1.zip | |||
unzip objects_v0.1.zip -d data/objects/ | |||
rm objects_v0.1.zip | |||
wget http://dl.fbaipublicfiles.com/habitat/locobot_merged.zip | |||
unzip locobot_merged.zip -d data/objects/ | |||
rm locobot_merged.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the workflow now after reading this. I had initially unzipped locobot_merged into the data/locobot_merged folder and was surprised when the example script crashed. (I do now see that in your instructions, you do ask them to be unzipped into data/objects/)
Instead of dumping everything into a single objects folder, would it be better to unzip locobot_merged.zip into data/locobot_merged so that way each asset-dataset is contained in it's own folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, in this case it may be best to add another directory like we have for scenes (data/scene_datasets/
) and do data/object_datasets/objects/
and data/object_datasets/locobot_merged/
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing this would break some existing user workflows I think. Let's talk about data organization and make a separate PR to update things to clarify the breaking nature of this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
Reviewing this PR was like unwrapping a basket of gifts. So many goodies. |
* master: Interactive RigidObject python tutorial page (#611) Update README.md Separate Scene And Object functionality into different classes (#628) Updated m.css submodule. (#627) Update agent state set state to be less confusing (#614) Direct Navmesh/Meshdata handling; PluginManager instance variable (#623) Documentation generator updates (#624) Update corrade submodule. (#618) Physics primitives (non-colliding) (#622) save_nav_mesh python bindings (#619) --Renamed GltfMeshData -> GenericMeshData; (#617) Update README.md Update README.md
* Added rigid object tutorial to Habitat-sim python pages. * update .circleci/config.yml to download locobot_merged asset for CI tutorial test
* master: Interactive RigidObject python tutorial page (facebookresearch#611) Update README.md Separate Scene And Object functionality into different classes (facebookresearch#628) Updated m.css submodule. (facebookresearch#627) Update agent state set state to be less confusing (facebookresearch#614) Direct Navmesh/Meshdata handling; PluginManager instance variable (facebookresearch#623) Documentation generator updates (facebookresearch#624) Update corrade submodule. (facebookresearch#618) Physics primitives (non-colliding) (facebookresearch#622) save_nav_mesh python bindings (facebookresearch#619) --Renamed GltfMeshData -> GenericMeshData; (facebookresearch#617) Update README.md Update README.md
Motivation and Context
Added a much needed tutorial for rigid object interactivity through the python Simulator API.
How Has This Been Tested
New tutorial code is run in
tests/test_examples.py
.Types of changes
Checklist