--Renamed GltfMeshData -> GenericMeshData; #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlftMeshData class functionality applies to other types of files, as well as Magnum primtives, and so is more appropriately considered generic mesh data.
facebook-github-bot
added
the
CLA Signed
mosra
reviewed
May 4, 2020
Codecov Report
@@ Coverage Diff @@
## master #617 +/- ##
==========================================
- Coverage 58.26% 58.20% -0.07%
==========================================
Files 130 130
Lines 5889 5890 +1
Branches 84 84
==========================================
- Hits 3431 3428 -3
- Misses 2458 2462 +4
Continue to review full report at Codecov.
|
jturner65
force-pushed
the
RenameGltfMeshData
branch
from
acbc7ee
to
34a5a6b
Compare
jturner65
changed the title
mosra
approved these changes
May 5, 2020
aclegg3
approved these changes
May 5, 2020
dhruvbatra
pushed a commit
that referenced
this pull request
May 13, 2020
* master: Interactive RigidObject python tutorial page (#611) Update README.md Separate Scene And Object functionality into different classes (#628) Updated m.css submodule. (#627) Update agent state set state to be less confusing (#614) Direct Navmesh/Meshdata handling; PluginManager instance variable (#623) Documentation generator updates (#624) Update corrade submodule. (#618) Physics primitives (non-colliding) (#622) save_nav_mesh python bindings (#619) --Renamed GltfMeshData -> GenericMeshData; (#617) Update README.md Update README.md
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
* --Renamed GlftMeshData -> GenericMeshData; GlftMeshData class functionality applies to other types of files, as well as Magnum primtives, and so is more appropriately considered generic mesh data. * --Address reviewer comments.
Ram81
pushed a commit
to Ram81/habitat-web-sim
that referenced
this pull request
Dec 10, 2020
* master: Interactive RigidObject python tutorial page (facebookresearch#611) Update README.md Separate Scene And Object functionality into different classes (facebookresearch#628) Updated m.css submodule. (facebookresearch#627) Update agent state set state to be less confusing (facebookresearch#614) Direct Navmesh/Meshdata handling; PluginManager instance variable (facebookresearch#623) Documentation generator updates (facebookresearch#624) Update corrade submodule. (facebookresearch#618) Physics primitives (non-colliding) (facebookresearch#622) save_nav_mesh python bindings (facebookresearch#619) --Renamed GltfMeshData -> GenericMeshData; (facebookresearch#617) Update README.md Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This PR renames the GltfMeshData class to be GenericMeshData, to more accurately reflect this class's applicability to many different mesh formats. A method was added to instance a mesh object by the importer using a string name, in order to support mesh instancing using PrimitiveImporter.
How Has This Been Tested
All existing c++ and python tests
Types of changes
Checklist