[Cloud Security] [Vulnerabilities] Remove flyout pagination #169301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opauloh
added
Team:Cloud Security
|
Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security) |
opauloh
changed the title
opauloh
added
the
release_note:skip
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
maxcold
approved these changes
Oct 19, 2023
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 19, 2023
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 19, 2023
…169301) (#169435) # Backport This will backport the following commits from `main` to `8.11`: - [[Cloud Security] [Vulnerabilities] Remove flyout pagination (#169301)](#169301) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulo Henrique","email":"paulo.henrique@elastic.co"},"sourceCommit":{"committedDate":"2023-10-19T17:01:59Z","message":"[Cloud Security] [Vulnerabilities] Remove flyout pagination (#169301)","sha":"8b54eed4babedf7dbc947ec44b3f516a00d790f7","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v8.12.0"],"number":169301,"url":"https://github.com/elastic/kibana/pull/169301","mergeCommit":{"message":"[Cloud Security] [Vulnerabilities] Remove flyout pagination (#169301)","sha":"8b54eed4babedf7dbc947ec44b3f516a00d790f7"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/169301","number":169301,"mergeCommit":{"message":"[Cloud Security] [Vulnerabilities] Remove flyout pagination (#169301)","sha":"8b54eed4babedf7dbc947ec44b3f516a00d790f7"}}]}] BACKPORT--> Co-authored-by: Paulo Henrique <paulo.henrique@elastic.co>
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Oct 22, 2023
benakansara
pushed a commit
to benakansara/kibana
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #169247
This PR addresses a regression introduced on #167844, when adding the same container and virtualization to the Vulnerabilities table it lost the ability to paginate through the Flyout. To address that this PR is removing the Flyout pagination (as it was already done on the Findings page).
We are okay with removing the flyout pagination at the moment as it is part of a further enhancement we are currently working on the findings page, there's a ticket about adding that capability back on the future.
Screenshots