-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Cloud Security] Add Fields selector to the CloudSecurityDataTable #167844
[Cloud Security] Add Fields selector to the CloudSecurityDataTable #167844
Conversation
…to unified-data-grid/foundation
...ugins/cloud_security_posture/public/components/cloud_security_data_table/fields_selector.tsx
Show resolved
Hide resolved
…-ref HEAD~1..HEAD --fix'
…' into unified-data-grid/column-toggler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! NICE WORK!
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…lastic#167844) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: @Omolola-Akinleye (cherry picked from commit 0c71076)
…able (#167844) (#168162) # Backport This will backport the following commits from `main` to `8.11`: - [[Cloud Security] Add Fields selector to the CloudSecurityDataTable (#167844)](#167844) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulo Henrique","email":"paulo.henrique@elastic.co"},"sourceCommit":{"committedDate":"2023-10-05T21:40:59Z","message":"[Cloud Security] Add Fields selector to the CloudSecurityDataTable (#167844)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: @Omolola-Akinleye","sha":"0c71076f92de0951fc66c62be69c68735ada7949","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v8.11.0","v8.12.0"],"number":167844,"url":"https://github.com/elastic/kibana/pull/167844","mergeCommit":{"message":"[Cloud Security] Add Fields selector to the CloudSecurityDataTable (#167844)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: @Omolola-Akinleye","sha":"0c71076f92de0951fc66c62be69c68735ada7949"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167844","number":167844,"mergeCommit":{"message":"[Cloud Security] Add Fields selector to the CloudSecurityDataTable (#167844)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: @Omolola-Akinleye","sha":"0c71076f92de0951fc66c62be69c68735ada7949"}}]}] BACKPORT--> Co-authored-by: Paulo Henrique <paulo.henrique@elastic.co>
…lastic#167844) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: @Omolola-Akinleye
Summary
It closes #165786
Note: This PR is based on this branch, and #167587 must be merged first. Refer here for the file diffThis PR adds a Fields button in the
CloudSecurityDataTable
component. Clicking on the Fields button opens a Modal that allow users to select which Fields from the DataView to display in the DataTable. The selected fields are then persisted in theLocalStorage
.It also addresses some design inconsistencies stated here between the Vulnerabilities Table and the new Findings Table.
Screenshot