[Cloud Security] Add Fields selector to the CloudSecurityDataTable #167844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to unified-data-grid/foundation
opauloh
added
the
backport:prev-minor
3 tasks
opauloh
removed
ci:cloud-deploy
animehart
reviewed
Oct 5, 2023
...ugins/cloud_security_posture/public/components/cloud_security_data_table/fields_selector.tsx
Show resolved
Hide resolved
…-ref HEAD~1..HEAD --fix'
Omolola-Akinleye
requested review from
Omolola-Akinleye
and removed request for
Omolola-Akinleye
…' into unified-data-grid/column-toggler
Omolola-Akinleye
approved these changes
Oct 5, 2023
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2023
…lastic#167844) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: @Omolola-Akinleye (cherry picked from commit 0c71076)
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2023
…able (#167844) (#168162) # Backport This will backport the following commits from `main` to `8.11`: - [[Cloud Security] Add Fields selector to the CloudSecurityDataTable (#167844)](#167844) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Paulo Henrique","email":"paulo.henrique@elastic.co"},"sourceCommit":{"committedDate":"2023-10-05T21:40:59Z","message":"[Cloud Security] Add Fields selector to the CloudSecurityDataTable (#167844)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: @Omolola-Akinleye","sha":"0c71076f92de0951fc66c62be69c68735ada7949","branchLabelMapping":{"^v8.12.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Cloud Security","backport:prev-minor","v8.11.0","v8.12.0"],"number":167844,"url":"https://github.com/elastic/kibana/pull/167844","mergeCommit":{"message":"[Cloud Security] Add Fields selector to the CloudSecurityDataTable (#167844)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: @Omolola-Akinleye","sha":"0c71076f92de0951fc66c62be69c68735ada7949"}},"sourceBranch":"main","suggestedTargetBranches":["8.11"],"targetPullRequestStates":[{"branch":"8.11","label":"v8.11.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.12.0","labelRegex":"^v8.12.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/167844","number":167844,"mergeCommit":{"message":"[Cloud Security] Add Fields selector to the CloudSecurityDataTable (#167844)\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: @Omolola-Akinleye","sha":"0c71076f92de0951fc66c62be69c68735ada7949"}}]}] BACKPORT--> Co-authored-by: Paulo Henrique <paulo.henrique@elastic.co>
dej611
pushed a commit
to dej611/kibana
that referenced
this pull request
Oct 17, 2023
…lastic#167844) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: @Omolola-Akinleye
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It closes #165786
Note: This PR is based on this branch, and #167587 must be merged first. Refer here for the file diffThis PR adds a Fields button in the
CloudSecurityDataTablecomponent. Clicking on the Fields button opens a Modal that allow users to select which Fields from the DataView to display in the DataTable. The selected fields are then persisted in theLocalStorage.It also addresses some design inconsistencies stated here between the Vulnerabilities Table and the new Findings Table.
Screenshot