[Cloud Security] [Vulnerabilities] Remove flyout pagination (#169301)

elastic · Oct 19, 2023 · 8b54eed · 8b54eed
1 parent 47cea09
commit 8b54eed
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 27 deletions.
diff --git a/x-pack/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities.tsx b/x-pack/plugins/cloud_security_posture/public/pages/vulnerabilities/vulnerabilities.tsx
@@ -268,22 +268,6 @@ const VulnerabilitiesDataGrid = ({
     isFetching,
   ]);
 
-  const onPaginateFlyout = useCallback(
-    (nextVulnerabilityIndex: number) => {
-      // the index of the vulnerability in the current page
-      const newVulnerabilityIndex = nextVulnerabilityIndex % pageSize;
-
-      // if the vulnerability is not in the current page, we need to change the page
-      const flyoutPageIndex = Math.floor(nextVulnerabilityIndex / pageSize);
-
-      setUrlQuery({
-        pageIndex: flyoutPageIndex,
-        vulnerabilityIndex: newVulnerabilityIndex,
-      });
-    },
-    [pageSize, setUrlQuery]
-  );
-
   const showVulnerabilityFlyout = flyoutVulnerabilityIndex > invalidIndex;
 
   if (data?.page.length === 0) {
@@ -372,7 +356,6 @@ const VulnerabilitiesDataGrid = ({
           flyoutIndex={selectedVulnerabilityIndex}
           vulnerabilityRecord={selectedVulnerability}
           totalVulnerabilitiesCount={limitedTotalItemCount}
-          onPaginate={onPaginateFlyout}
           closeFlyout={onCloseFlyout}
           isLoading={isFetching}
         />

diff --git a/...lic/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_flyout.tsx b/...lic/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_flyout.tsx
@@ -88,7 +88,7 @@ export const VulnerabilityFindingFlyout = ({
   isLoading,
 }: {
   closeFlyout: () => void;
-  onPaginate: (pageIndex: number) => void;
+  onPaginate?: (pageIndex: number) => void;
   totalVulnerabilitiesCount: number;
   flyoutIndex?: number;
   vulnerabilityRecord: CspVulnerabilityFinding;
@@ -236,15 +236,21 @@ export const VulnerabilityFindingFlyout = ({
         </EuiSkeletonText>
       </EuiFlyoutBody>
       <EuiFlyoutFooter>
-        <EuiFlexGroup gutterSize="none" alignItems="center" justifyContent="spaceBetween">
-          <EuiFlexItem grow={false}>
-            <EuiPagination
-              pageCount={totalVulnerabilitiesCount}
-              activePage={flyoutIndex}
-              onPageClick={onPaginate}
-              compressed
-            />
-          </EuiFlexItem>
+        <EuiFlexGroup
+          gutterSize="none"
+          alignItems="center"
+          justifyContent={onPaginate ? 'spaceBetween' : 'flexEnd'}
+        >
+          {onPaginate && (
+            <EuiFlexItem grow={false}>
+              <EuiPagination
+                pageCount={totalVulnerabilitiesCount}
+                activePage={flyoutIndex}
+                onPageClick={onPaginate}
+                compressed
+              />
+            </EuiFlexItem>
+          )}
           <EuiFlexItem grow={false}>
             <TakeAction createRuleFn={createVulnerabilityRuleFn} />
           </EuiFlexItem>