Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UnifiedDataTable] Add support to Flyout Pagination in the UnifiedDataTable component #168619

Open
3 tasks
opauloh opened this issue Oct 11, 2023 · 5 comments
Open
3 tasks
Labels
Feature:Cloud-Security Cloud Security related features good first issue low hanging fruit Team:Cloud Security Cloud Security team related

Comments

@opauloh
Copy link
Contributor

opauloh commented Oct 11, 2023

Motivation

Currently, the UnifiedDataTable component doesn't provide a way to allow us to have Flyout Pagination controls, the primary goal is to implement that support in a way that Flyouts opened by the CloudSecurity DataTable have paginations, a secondary goal is to add that support in the shared UnifiedDataTable itself, so all consumers can enable Flyout pagination if desired.

Definition of done

  • The Flyouts opened by the CloudSecurity DataTable has pagination
  • Pagination in the Flyout as an optional property of the UnifiedDataTable: showExpandedDocPagination: true | false
  • The property in the UnifiedDataTable is optional and defaults to false

Out of scope

  • Advanced controls or customizations for the Flyout Pagination

Team tag

@elastic/kibana-cloud-security-posture

Related

#169247

@kfirpeled
Copy link
Contributor

moved to 8.14

@opauloh
Copy link
Contributor Author

opauloh commented Feb 7, 2024

Update: It looks like Flyout Pagination is now supported by the Unified Data Table

Image

I'm going to confirm that information and we agreed in the Findings enhancement sync that we are going to prioritize this ticket in case in case the support is already implemented and we just need to "enable" it

@opauloh
Copy link
Contributor Author

opauloh commented Mar 13, 2024

Update:

Flyout pagination is possible using the setExpandedDoc method, as currently implemented here by the DiscoverGridFlyout component, alternatively is also possible to use the Discover Flyout since it's possible to add custom tabs, this way we would get the benefits of having the Actions available in the Table tab.

@kfirpeled
Copy link
Contributor

Hi Paulo, happy to hear there's a possibility to add the support for pagination through our flyout

this way we would get the benefits of having the Actions available in the Table tab.

I don't see how these actions are relevant to our use case. So in that case, would that be a limitation for us if we don't want to include that?

@opauloh
Copy link
Contributor Author

opauloh commented Mar 14, 2024

If we use the DiscoverGridFlyout we get access to the paginations, Actions on the Header, and Actions on the Table

Screenshot 2024-03-14 at 11 58 04 AM

The compromise is that we can't customize the Title as we have today, and also that the Flyout doesn't have an overlay background.

Screenshot 2024-03-14 at 1 24 58 PM

I don't see how these actions are relevant to our use case. So in that case, would that be a limitation for us if we don't want to include that?

If the benefits are not appealing to include in our use case, it's best if we add the pagination to our flyout using the setExpandedDoc method than trying to disable the features we don't want to in the DiscoverGridFlyout, there's no limitation on handling the pagination ourselves.

@kfirpeled kfirpeled added good first issue low hanging fruit and removed 8.14 candidate labels Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Cloud-Security Cloud Security related features good first issue low hanging fruit Team:Cloud Security Cloud Security team related
Projects
None yet
Development

No branches or pull requests

2 participants