[Cloud Security] [Vulnerabilities] Add grouping capabilities #174413

opauloh · 2024-01-06T02:34:14Z

Summary

It closes #165788 and #169050 and #174119

This PR adds the following changes to the Findings -> Vulnerabilities page:

Replaced the DataGrid component with the new CloudSecurityDataTable component
Added the new Grouping component with custom default renderers

It also introduced the following changes:

Added context for DataView for easier reuse of the dataView methods.
Refactored the Misconfigurations component to consume the dataView context
added FTR tests for the Vulnerabilities page
dropped Flyout navigation support (will be readded in the future)

Screenshots

Recording

Screen.Recording.2024-01-09.at.12.09.57.PM.mov

Screen.Recording.2024-01-09.at.12.09.04.PM.mov

elasticmachine · 2024-01-09T20:08:13Z

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

maxcold · 2024-01-10T16:11:46Z

Tested in local, one problem I found is that the grouping is preserved when switching between Misconfigurations and Vulnerabilities. I'm not sure if it is expected behavior plus it broke the UI in the case when I chose "group be k8s cluster" and navigated to vulnerabilities

maxcold

started with the review, found couple of skipped tests and commented out code. Will continue tomorrow

maxcold · 2024-01-10T15:39:41Z

...c/pages/vulnerabilities/vulnerabilities_finding_flyout/vulnerability_finding_flyout.test.tsx

@@ -93,15 +93,15 @@ describe('<VulnerabilityFindingFlyout/>', () => {
    });
  });

-  it('should allow pagination with next', async () => {
+  it.skip('should allow pagination with next', async () => {


what's the reason for skipping? do you plan to unskip in the context of this PR or do you see it as a tech debt?

Exactly, I skipped those tests because there's a plan to re-enable them later once #168619 is resolved. I added a TODO comment now on the skipped tests so we can know when to re-enable them.

x-pack/plugins/cloud_security_posture/server/plugin.ts

…/github.com/opauloh/kibana into findings-enhancements/vulnerabilities-table

opauloh · 2024-01-10T23:54:49Z

Tested in local, one problem I found is that the grouping is preserved when switching between Misconfigurations and Vulnerabilities. I'm not sure if it is expected behavior plus it broke the UI in the case when I chose "group be k8s cluster" and navigated to vulnerabilities

Thanks for catching this, I split the keys and enforced to prevent unintentionally sharing the local storage by adding a groupingLocalStorageKey prop to the useCloudSecurityGrouping hook

maxcold

lgtm overall, there are a couple of things I want to clarify before approving

x-pack/plugins/cloud_security_posture/public/common/api/use_latest_findings_data_view.ts

x-pack/plugins/cloud_security_posture/public/pages/vulnerabilities/constants.ts

...ins/cloud_security_posture/public/pages/vulnerabilities/hooks/use_latest_vulnerabilities.tsx

maxcold · 2024-01-11T16:40:12Z

...loud_security_posture/public/pages/vulnerabilities/latest_vulnerabilities_group_renderer.tsx

+/**
+ * Return first non-null value. If the field contains an array, this will return the first value that isn't null. If the field isn't an array it'll be returned unless it's null.
+ */
+export function firstNonNullValue<T>(valueOrCollection: ECSField<T>): T | undefined {


I think this exists for findings as well. Worth sharing the code between the two?

and maybe it's true for some of the components in this file as well, the ones which are not specific for vulnerabilties

That was a great idea, I ended up sharing the common components and utils in the cloud_security_grouping folder

…-fix'

maxcold · 2024-01-12T09:46:40Z

Approving, but there is one comment unanswered about the code duplication in the latest_vulnerabilities_group_renderer.tsx #174413 (comment) . Pls check that before merging

…/github.com/opauloh/kibana into findings-enhancements/vulnerabilities-table

kibana-ci · 2024-01-13T01:14:18Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: a03865e

Failed CI Steps

Serverless Osquery Cypress Tests #6

Test Failures

[job] [logs] Serverless Osquery Cypress Tests #6 / App Features for Enpoint Complete PLI response actions should be available response actions should be available

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`cloudSecurityPosture`	407	391	-16

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`cloudSecurityPosture`	415.5KB	372.9KB	-42.6KB

History

💔 Build #187329 failed 0abccc4
💛 Build #187093 was flaky a32e1f6
💛 Build #187074 was flaky a8375c1
💛 Build #186913 was flaky 1c741a8
💚 Build #186732 succeeded 7680749

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…#174413) ## Summary It closes elastic#165788 and elastic#169050 and elastic#174119 This PR adds the following changes to the Findings -> Vulnerabilities page: - Replaced the DataGrid component with the new CloudSecurityDataTable component - Added the new Grouping component with custom default renderers It also introduced the following changes: - Added context for DataView for easier reuse of the `dataView` methods. - Refactored the Misconfigurations component to consume the `dataView` context - added FTR tests for the Vulnerabilities page - dropped Flyout navigation support (will be readded in the future) ## Screenshots ![image](https://github.com/elastic/kibana/assets/19270322/c6cb7871-ce99-4c33-a615-142aaba63ec9) ![image](https://github.com/elastic/kibana/assets/19270322/ead3358f-7300-489b-b26d-5a37cc99e01d) ## Recording https://github.com/elastic/kibana/assets/19270322/a47be0cf-2849-424d-b19a-d65cb6f502a8 https://github.com/elastic/kibana/assets/19270322/fa395488-7a22-476e-a50e-d0f0e28429e1 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

opauloh added 10 commits December 19, 2023 08:33

wip: vulnerabilities datatable

ebbf0c5

Merge branch 'main' into findings-enhancements/vulnerabilities-table

4e90034

WIP: Vulnerabilities DataTable

0a0b005

Merge branch 'main' into findings-enhancements/vulnerabilities-table

528df5e

adding data view context

4c33137

handling null data

0878bbb

updating findings table with new dataview context

243d46f

vulnerabilities datatable and grouping

8004701

empty component condition

23caa12

FTR tests

a72df4b

opauloh added release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.13.0 labels Jan 6, 2024

This was linked to issues Jan 6, 2024

[Cloud Security] [Findings++ Phase 2] [Vulnerabilities] Update "vulnerabilities" to use new grouping component #169050

Closed

[Cloud Posture] [Tech Debt] refactor dataView into a context #174119

Closed

fixing unit tests / removing unused

0a3b17d

opauloh marked this pull request as ready for review January 9, 2024 20:08

opauloh requested a review from a team as a code owner January 9, 2024 20:08

opauloh added 11 commits January 9, 2024 12:10

Merge branch 'main' into findings-enhancements/vulnerabilities-table

43df0e5

removing unused

466de2c

Fixing variable names

5f2669b

show timestamp on the field selector modal

d6757e8

remove unused hook

c5188fa

adding fields to constant

e77452b

removing unused code fixing tsc checks

ba611e9

remove unused translations

daf4953

fix FTR tests

aafa7bc

fixing ftr test vulnerability

0016729

Merge branch 'main' into findings-enhancements/vulnerabilities-table

7680749

maxcold requested changes Jan 10, 2024

View reviewed changes

opauloh added 5 commits January 10, 2024 15:25

remove comment

4f3de1f

Merge branch 'findings-enhancements/vulnerabilities-table' of https:/…

f86902d

…/github.com/opauloh/kibana into findings-enhancements/vulnerabilities-table

adding skip description

80eb3e6

Merge branch 'main' into findings-enhancements/vulnerabilities-table

0e16728

split grouping local storage key

8414c13

opauloh requested a review from maxcold January 10, 2024 23:55

make severity sorting behavior to match the sorting text

1c741a8

maxcold reviewed Jan 11, 2024

View reviewed changes

opauloh and others added 3 commits January 11, 2024 13:11

Addressing PR comments

a8375c1

Merge branch 'main' into findings-enhancements/vulnerabilities-table

26753f9

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

a32e1f6

…-fix'

opauloh requested a review from maxcold January 12, 2024 05:34

maxcold approved these changes Jan 12, 2024

View reviewed changes

opauloh added 3 commits January 12, 2024 14:10

share renderers grouping components

71777df

Merge branch 'findings-enhancements/vulnerabilities-table' of https:/…

0abccc4

…/github.com/opauloh/kibana into findings-enhancements/vulnerabilities-table

Merge branch 'main' into findings-enhancements/vulnerabilities-table

a03865e

opauloh merged commit c348925 into elastic:main Jan 13, 2024
20 checks passed

kibanamachine added the backport:skip This commit does not require backporting label Jan 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Cloud Security] [Vulnerabilities] Add grouping capabilities #174413

[Cloud Security] [Vulnerabilities] Add grouping capabilities #174413

opauloh commented Jan 6, 2024 •

edited

Loading

elasticmachine commented Jan 9, 2024

maxcold commented Jan 10, 2024

maxcold left a comment

maxcold Jan 10, 2024

opauloh Jan 10, 2024 •

edited

Loading

opauloh commented Jan 10, 2024

maxcold left a comment

maxcold Jan 11, 2024

maxcold Jan 11, 2024

opauloh Jan 12, 2024

maxcold commented Jan 12, 2024

kibana-ci commented Jan 13, 2024

[Cloud Security] [Vulnerabilities] Add grouping capabilities #174413

[Cloud Security] [Vulnerabilities] Add grouping capabilities #174413

Conversation

opauloh commented Jan 6, 2024 • edited Loading

Summary

Screenshots

Recording

elasticmachine commented Jan 9, 2024

maxcold commented Jan 10, 2024

maxcold left a comment

Choose a reason for hiding this comment

maxcold Jan 10, 2024

Choose a reason for hiding this comment

opauloh Jan 10, 2024 • edited Loading

Choose a reason for hiding this comment

opauloh commented Jan 10, 2024

maxcold left a comment

Choose a reason for hiding this comment

maxcold Jan 11, 2024

Choose a reason for hiding this comment

maxcold Jan 11, 2024

Choose a reason for hiding this comment

opauloh Jan 12, 2024

Choose a reason for hiding this comment

maxcold commented Jan 12, 2024

kibana-ci commented Jan 13, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

History

opauloh commented Jan 6, 2024 •

edited

Loading

opauloh Jan 10, 2024 •

edited

Loading