Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): v4.6.0 #3823

Closed
wants to merge 27 commits into from
Closed

chore(release): v4.6.0 #3823

wants to merge 27 commits into from

Conversation

attest-team-ci
Copy link
Contributor

4.6.0 (2022-12-09)

Features

  • aria-required-attr: require aria-controls on combobox and aria-valuenow on focusable separator (#3786) (5259e88)
  • checks/label-content-name-mismatch: deprecate occuranceThreshold option in favor of occurrenceThreshold to fix typo (#3782) (5026d65)
  • commons: deprecate flattenShadowColors in favor of flattenColors (#3792) (af49daf)
  • context: allow selecting shadow DOM nodes (#3798) (9e1e31b)
  • list,listitem: do not allow group as allowed parent or child (#3784) (d1cbf6f)
  • required-attr: require aria-checked for checkbox-like and radio-like roles (#3785) (563e4e9)
  • utils: new shadowSelectAll utility (#3796) (5865462)

Bug Fixes

  • aria-allowed-role: allow combobox on button, checkbox and combobox on input[type=button] (#3354) (ac688c0), closes #3353
  • color-contrast: consider -webkit-text-stroke & -webkit-text-fill-color (#3791) (228daf1)
  • color-contrast: correctly calculate background color of text nodes with different size than their container (#3703) (123b83c)
  • get-role: handle presentation role inheritance for vnodes with no parent (#3801) (b971caf)
  • html-lang-valid: only run rule when attribute has value (#3663) (1a7eecb), closes #3624
  • metadata: Map aria-required-children to ACT rule bc4a75 (#3790) (a33a523)

This PR was opened by a robot 🤖 🎉

straker and others added 27 commits November 14, 2022 14:30
chore: merge master into develop
…valuenow on focusable separator (#3786)

* feat(aria-required-attr): require aria-controls on combobox and aria-valuenow on focusable separator

* integration tests
…3784)

* feat(list,listitem): do not allow group as allowed parent or child

* fix tests
…-like roles (#3785)

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
* fix(metadata): Map aria-required-children to ACT rule bc4a75

* Update rule-desc
* fix(context): Allow multiple strings for include/exclude

* Complete refactor
* feat(utils): new shadowSelectAll utility

* Apply suggestions from code review

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
…-color (#3791)

* fix(color-contrast): use text-stroke colors

* Use textStrokeEmMin option in contrast checks

* address comment

* Editorial

* Update test/commons/color/get-foreground-color.js

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
…ox on input[type=button] (#3354)

* Update allowed button & input type=button roles

closes #3353

- Adds `role=combobox` to the `<button>` element.
- Adds `role=combobox` and `role=checkbox` to the `<input type=button>` element.

* fix whitespace

* add pass ids

* `button role=combobox`
* `input type=button role=combobox`
* `input type=button role=checkbox`

* add tests

* `button role=combobox`
* `input type=button role=combobox`
* `input type=button role=checkbox`

Co-authored-by: Steven Lambert <steven.lambert@deque.com>
* Change html-lang-valid selector so the rule only applies when attrs have a value. Fix #3624

* add integration tests

Co-authored-by: Steven Lambert <steven.lambert@deque.com>
…d option in favor of occurrenceThreshold to fix typo (#3782)

* Correct typos of "occurrence" across axe-core.

* Correct Markdown table spacing.

* Add fix to accomodate previous typos to avoid breaking the API per WilcoFiers' suggestions.

* Account for old spelling in subtreeText and minor formatting.

* run tests

* Add null-aware chaining where necessary.

* run tests

Co-authored-by: Steven Lambert <steven.lambert@deque.com>
* feat(context): allow scoping shadow DOM nodes

* Refactor Context code

* Code complete

* cleanup

* Fix tests

* Update type definition

* Write docs

* Apply suggestions from code review

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* Resolve comments

* Add type definition tests

* Apply suggestions from code review

Co-authored-by: Erik Larsen <enlarsen@users.noreply.github.com>
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* Update context.md

* fix test

* Update type test

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
Co-authored-by: Erik Larsen <enlarsen@users.noreply.github.com>
* chore: improve type definitions

* Apply suggestions from code review

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
* ci: fix nightly test

* add back filter
Co-authored-by: michael-siek <michael-siek@users.noreply.github.com>
* Update config.yml

* Update config.yml
* ci: Add a workflow for creating releases

Ref dequelabs/axe-api-team#304

* testing

* all commits

* push branch

* pat

* this repo still uses master

* remove testing stuff

* 🤖 Automated formatting fixes

* Update .github/workflows/release.yml

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

* Update .github/workflows/release.yml

Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>

Co-authored-by: stephenmathieson <stephenmathieson@users.noreply.github.com>
Co-authored-by: Steven Lambert <2433219+straker@users.noreply.github.com>
…es with different size than their container (#3703)

* fix(color-contrast): correctly calculate background color of text nodes with different size than their container

* undo file rename

* fix test

* remove export

* test name

* comment

* undeprecate for this pr

* tests

* fix test

* fix firefox test

* fix bug

* firefox...

* firefox ci is annoying

* fix test?

* new lint

* sigh...

* :P

* :P

* works now?

* Update lib/commons/color/get-background-color.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update lib/commons/color/get-background-color.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update lib/commons/math/get-intersection-rect.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update lib/commons/math/get-intersection-rect.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update lib/commons/math/get-intersection-rect.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* changes

* Update lib/commons/color/get-background-stack.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update lib/commons/color/get-background-color.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* Update lib/commons/dom/get-visible-text-rects.js

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>

* changes

* 🤖 Automated formatting fixes

* suggestions

* suggestions

* rename

Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: straker <straker@users.noreply.github.com>
@attest-team-ci attest-team-ci requested a review from a team as a code owner December 9, 2022 17:30
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
9 out of 10 committers have signed the CLA.

✅ michael-siek
✅ straker
✅ thibaudcolas
✅ scottaohara
✅ WilcoFiers
✅ nolandanley
✅ dbowling
✅ stephenmathieson
✅ piwysocki
❌ attest-team-ci
You have signed the CLA already but the status is still pending? Let us recheck it.

@WilcoFiers WilcoFiers closed this Dec 12, 2022
@WilcoFiers WilcoFiers deleted the release-2022-12-09 branch December 12, 2022 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.