feat(checks/label-content-name-mismatch): deprecate occuranceThreshold option in favor of occurrenceThreshold to fix typo #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
WilcoFiers
previously requested changes
Nov 15, 2022
| @@ -104,11 +104,11 @@ function shouldIgnoreHidden(virtualNode, context) { | |||
| * @return {Boolean} | |||
| */ | |||
| function shouldIgnoreIconLigature(virtualNode, context) { | |||
| const { ignoreIconLigature, pixelThreshold, occuranceThreshold } = context; | |||
| const { ignoreIconLigature, pixelThreshold, occurrenceThreshold } = context; | |||
There was a problem hiding this comment.
This should avoid a break in the API.
Suggested change
| const { ignoreIconLigature, pixelThreshold, occurrenceThreshold } = context; | |
| const { ignoreIconLigature, pixelThreshold } = context; | |
| const occurrenceThreshold = context.occurrenceThreshold ?? context.occurenceThreshold |
There was a problem hiding this comment.
Thanks for this! I think you mean "occuranceThreshold" since that was the only version of the typo used in code. "Occurence" was only used in a comment. Added this modified fix in 22d9b95a1d851fae3c850f0a5f125a4ba8bf0438.
…lcoFiers' suggestions.
straker
previously requested changes
Nov 16, 2022
There was a problem hiding this comment.
Thanks, looking good so far, just need to update the name in one more place. Also, since we're going to deprecate the old name we'll need to update the pr title to match conventional commits. We deprecate things as a feat and want to make sure the title says which thing is deprecated, and either the pr title or body should say what to use instead.
nolandanley
changed the title
nolandanley
changed the title
nolandanley
requested review from
straker and
WilcoFiers
and removed request for
WilcoFiers and
straker
straker
previously requested changes
Nov 29, 2022
straker
approved these changes
Nov 30, 2022
|
Reviewed for security |
straker
changed the title
straker
changed the title
This was referenced Dec 5, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes typos of the word "occurrence" throughout axe-core.