Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix prettier GHA #3813

Merged
merged 5 commits into from
Dec 5, 2022
Merged

ci: fix prettier GHA #3813

merged 5 commits into from
Dec 5, 2022

Conversation

michael-siek
Copy link
Member

<< Describe the changes >>

Closes issue:

@michael-siek michael-siek requested a review from a team as a code owner December 5, 2022 16:59
stephenmathieson
stephenmathieson approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@stephenmathieson stephenmathieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but should get @straker or @WilcoFiers to sign off

straker
straker approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@straker straker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we won't know if this setup works with 3rd party contributors until it happens. Hopefully it works out there too.

@michael-siek michael-siek merged commit 3fe4901 into develop Dec 5, 2022
@michael-siek michael-siek deleted the ci/fix/prettier branch December 5, 2022 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephenmathieson stephenmathieson stephenmathieson approved these changes

@straker straker straker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-siek @stephenmathieson @straker