fix(color-contrast): correctly calculate background color of text nodes with different size than their container #3703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es with different size than their container
straker
changed the title
straker
changed the title
straker
force-pushed
the
color-contrast-text-rects
branch
from
092ff52
to
9c79ddb
Compare
WilcoFiers
requested changes
Nov 8, 2022
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
WilcoFiers
previously requested changes
Nov 28, 2022
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
Co-authored-by: Wilco Fiers <WilcoFiers@users.noreply.github.com>
…abs/axe-core into color-contrast-text-rects
WilcoFiers
reviewed
Dec 7, 2022
WilcoFiers
previously requested changes
Dec 7, 2022
WilcoFiers
previously requested changes
Dec 8, 2022
WilcoFiers
reviewed
Dec 8, 2022
|
|
||
| const overflow = vNode.getComputedStylePropertyValue('overflow'); | ||
|
|
||
| if (overflow === 'hidden') { |
There was a problem hiding this comment.
Should have a ticket for overflow-x: hidden overflow-y: visible.
WilcoFiers
previously approved these changes
Dec 8, 2022
WilcoFiers
approved these changes
Dec 8, 2022
This was referenced Dec 9, 2022
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had an idea on how to improve the accuracy of our color contrast algorithm by looking at just the text rects (instead of trying to look at the bounding box of the element). This not only simplifies the algorithm a bit by removing a few in-between functions, but also fixes incorrect calculations of background color, such as in the following example which would report no contrast issues even though the text is fully on top of a dark background:
Also fixes a lot of different cases reporting partial overlap when they didn't need to.
This also deprecates
visually-contains,filteredRectStack, andgetRectStack, but I'll deprecate them in a separate pr.Closes issue: #3626
Closes issue: #3442
Closes issue: #3400
Closes issue: #3257