Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow: use CMakeDeps set property to match the expected Brotli names #17510

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented May 10, 2023

Specify library name and version: arrow/all

Instead of patching the CMakeLists to match the target names generated by CMakeDeps, use CMakeDep's ability to change the target names so that they match the ones in the CMakeLists instead - this should be more robust as patches tend to get lost across versions.

Close: #16059

@ghost
Copy link

ghost commented May 10, 2023

I detected other pull requests that are modifying arrow/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@ghost ghost mentioned this pull request May 10, 2023
3 tasks
@SpaceIm
Copy link
Contributor

SpaceIm commented May 10, 2023

I'm not sure it's robust to apache/arrow#14671 since 11.0.0

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@stale
Copy link

stale bot commented Oct 15, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 15, 2023
@ghost ghost mentioned this pull request Dec 6, 2023
@ghost ghost mentioned this pull request Dec 19, 2023
3 tasks
@jcar87 jcar87 force-pushed the lcc/maintenance/arrow-use-cmakedeps-set-property-for-brotli branch from a846479 to 6c46664 Compare January 26, 2024 11:27
@stale stale bot removed the stale label Jan 26, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 3 (6c46664be2a0840535630ad5dd5cb4200a839afa):

  • arrow/15.0.0:
    Didn't run or was cancelled before finishing

  • arrow/14.0.1:
    Didn't run or was cancelled before finishing

  • arrow/14.0.2:
    Didn't run or was cancelled before finishing

  • arrow/12.0.1:
    Didn't run or was cancelled before finishing

  • arrow/14.0.0:
    Didn't run or was cancelled before finishing

  • arrow/11.0.0:
    Didn't run or was cancelled before finishing

  • arrow/13.0.0:
    Didn't run or was cancelled before finishing

  • arrow/7.0.0:
    Didn't run or was cancelled before finishing

  • arrow/12.0.0:
    Didn't run or was cancelled before finishing

  • arrow/10.0.1:
    Didn't run or was cancelled before finishing

  • arrow/10.0.0:
    Didn't run or was cancelled before finishing

  • arrow/8.0.1:
    Didn't run or was cancelled before finishing

  • arrow/8.0.0:
    Didn't run or was cancelled before finishing

  • arrow/1.0.0:
    CI failed to create some packages (All logs)

    Logs for packageID bb501827e3b6046bc76f657d13c1fdfae13de585:
    [settings]
    arch=armv8
    build_type=Debug
    compiler=apple-clang
    compiler.libcxx=libc++
    compiler.version=13.0
    os=Macos
    [options]
    arrow:shared=False
    
    [...]
        return (__m64)__builtin_ia32_punpckhwd((__v4hi)__m1, (__v4hi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:260:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_punpckhdq'�[0m
        return (__m64)__builtin_ia32_punpckhdq((__v2si)__m1, (__v2si)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:287:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_punpcklbw'�[0m
        return (__m64)__builtin_ia32_punpcklbw((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:310:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_punpcklwd'�[0m
        return (__m64)__builtin_ia32_punpcklwd((__v4hi)__m1, (__v4hi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:331:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_punpckldq'�[0m
        return (__m64)__builtin_ia32_punpckldq((__v2si)__m1, (__v2si)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_paddb'; did you mean '__builtin_arm_addg'?�[0m
        return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;30mnote: �[0m'__builtin_arm_addg' declared here�[0m
    �[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;31merror: �[0m�[1mfirst argument of MTE builtin function must be a pointer ('__v8qi' (vector of 8 'char' values) invalid)�[0m
        return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^                    ~~~~~~~~~~~~
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:373:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_paddw'; did you mean '__builtin_arm_addg'?�[0m
        return (__m64)__builtin_ia32_paddw((__v4hi)__m1, (__v4hi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;30mnote: �[0m'__builtin_arm_addg' declared here�[0m
        return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:373:19: �[0m�[0;1;31merror: �[0m�[1mfirst argument of MTE builtin function must be a pointer ('__v4hi' (vector of 4 'short' values) invalid)�[0m
        return (__m64)__builtin_ia32_paddw((__v4hi)__m1, (__v4hi)__m2);
    �[0;1;32m                  ^                    ~~~~~~~~~~~~
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:394:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_paddd'; did you mean '__builtin_arm_addg'?�[0m
        return (__m64)__builtin_ia32_paddd((__v2si)__m1, (__v2si)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;30mnote: �[0m'__builtin_arm_addg' declared here�[0m
        return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:394:19: �[0m�[0;1;31merror: �[0m�[1mfirst argument of MTE builtin function must be a pointer ('__v2si' (vector of 2 'int' values) invalid)�[0m
        return (__m64)__builtin_ia32_paddd((__v2si)__m1, (__v2si)__m2);
    �[0;1;32m                  ^                    ~~~~~~~~~~~~
    �[0m�[0;1;31mfatal error: �[0m�[1mtoo many errors emitted, stopping now [-ferror-limit=]�[0m
    20 errors generated.
    make[2]: *** [src/arrow/CMakeFiles/arrow_objlib.dir/array/array_binary.cc.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    make[1]: *** [src/arrow/CMakeFiles/arrow_objlib.dir/all] Error 2
    make: *** [all] Error 2
    arrow/1.0.0: ERROR: Package 'bb501827e3b6046bc76f657d13c1fdfae13de585' build failed
    arrow/1.0.0: WARN: Build folder /Users/jenkins/w/prod-v1/bsr@2/98012/ddade/.conan/data/arrow/1.0.0/_/_/build/bb501827e3b6046bc76f657d13c1fdfae13de585/build/Debug
    ERROR: arrow/1.0.0: Error in build() method, line 539
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/Users/jenkins/w/prod-v1/bsr@2/98012/ddade/.conan/data/arrow/1.0.0/_/_/build/bb501827e3b6046bc76f657d13c1fdfae13de585/build/Debug" '--' '-j8'
    
  • arrow/2.0.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 3 (6c46664be2a0840535630ad5dd5cb4200a839afa):

  • arrow/15.0.0:
    Didn't run or was cancelled before finishing

  • arrow/14.0.1:
    Didn't run or was cancelled before finishing

  • arrow/14.0.2:
    Didn't run or was cancelled before finishing

  • arrow/14.0.0:
    Didn't run or was cancelled before finishing

  • arrow/12.0.1:
    Didn't run or was cancelled before finishing

  • arrow/8.0.0:
    Didn't run or was cancelled before finishing

  • arrow/7.0.0:
    Didn't run or was cancelled before finishing

  • arrow/8.0.1:
    Didn't run or was cancelled before finishing

  • arrow/12.0.0:
    Didn't run or was cancelled before finishing

  • arrow/10.0.1:
    Didn't run or was cancelled before finishing

  • arrow/11.0.0:
    Didn't run or was cancelled before finishing

  • arrow/13.0.0:
    Didn't run or was cancelled before finishing

  • arrow/10.0.0:
    Didn't run or was cancelled before finishing

  • arrow/2.0.0:
    Didn't run or was cancelled before finishing

  • arrow/1.0.0:
    CI failed to create some packages (All logs)

    Logs for packageID 22934cb8d275fc056eeaa69888b1901cf919eef7:
    [settings]
    arch=armv8
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=False
    
    [...]
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:287:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_punpcklbw'�[0m
        return (__m64)__builtin_ia32_punpcklbw((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:310:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_punpcklwd'�[0m
        return (__m64)__builtin_ia32_punpcklwd((__v4hi)__m1, (__v4hi)__m2);
    �[0;1;32m                  ^
    �[0m[  7%] Building CXX object src/arrow/CMakeFiles/arrow_objlib.dir/array/builder_binary.cc.o
    �[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:331:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_punpckldq'�[0m
        return (__m64)__builtin_ia32_punpckldq((__v2si)__m1, (__v2si)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_paddb'; did you mean '__builtin_arm_addg'?�[0m
        return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;30mnote: �[0m'__builtin_arm_addg' declared here�[0m
    �[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;31merror: �[0m�[1mfirst argument of MTE builtin function must be a pointer ('__v8qi' (vector of 8 'char' values) invalid)�[0m
        return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^                    ~~~~~~~~~~~~
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:373:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_paddw'; did you mean '__builtin_arm_addg'?�[0m
        return (__m64)__builtin_ia32_paddw((__v4hi)__m1, (__v4hi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;30mnote: �[0m'__builtin_arm_addg' declared here�[0m
        return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:373:19: �[0m�[0;1;31merror: �[0m�[1mfirst argument of MTE builtin function must be a pointer ('__v4hi' (vector of 4 'short' values) invalid)�[0m
        return (__m64)__builtin_ia32_paddw((__v4hi)__m1, (__v4hi)__m2);
    �[0;1;32m                  ^                    ~~~~~~~~~~~~
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:394:19: �[0m�[0;1;31merror: �[0m�[1muse of undeclared identifier '__builtin_ia32_paddd'; did you mean '__builtin_arm_addg'?�[0m
        return (__m64)__builtin_ia32_paddd((__v2si)__m1, (__v2si)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:352:19: �[0m�[0;1;30mnote: �[0m'__builtin_arm_addg' declared here�[0m
        return (__m64)__builtin_ia32_paddb((__v8qi)__m1, (__v8qi)__m2);
    �[0;1;32m                  ^
    �[0m�[1m/Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/13.0.0/include/mmintrin.h:394:19: �[0m�[0;1;31merror: �[0m�[1mfirst argument of MTE builtin function must be a pointer ('__v2si' (vector of 2 'int' values) invalid)�[0m
        return (__m64)__builtin_ia32_paddd((__v2si)__m1, (__v2si)__m2);
    �[0;1;32m                  ^                    ~~~~~~~~~~~~
    �[0m�[0;1;31mfatal error: �[0m�[1mtoo many errors emitted, stopping now [-ferror-limit=]�[0m
    20 errors generated.
    make[2]: *** [src/arrow/CMakeFiles/arrow_objlib.dir/array/array_binary.cc.o] Error 1
    make[2]: *** Waiting for unfinished jobs....
    [  8%] Building CXX object src/arrow/CMakeFiles/arrow_objlib.dir/array/builder_decimal.cc.o
    make[1]: *** [src/arrow/CMakeFiles/arrow_objlib.dir/all] Error 2
    make: *** [all] Error 2
    
    arrow/1.0.0: ERROR: 
    Package '22934cb8d275fc056eeaa69888b1901cf919eef7' build failed
    arrow/1.0.0: WARN: Build folder /Users/jenkins/w/prod-v2/bsr/81381/edaab/p/b/arrow9fb6ec6a9dd47/b/build/Release
    ERROR: arrow/1.0.0: Error in build() method, line 539
    	cmake.build()
    	ConanException: Error 2 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Copy link
Contributor

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

@github-actions github-actions bot closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants