-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow: modernize more for conan v2 (take two) #17521
arrow: modernize more for conan v2 (take two) #17521
Conversation
This comment has been minimized.
This comment has been minimized.
I detected other pull requests that are modifying arrow/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
Can anyone take a look at this please? |
ee126d0
to
14699ea
Compare
I've rebased the commit to the latest master. |
14699ea
to
130da37
Compare
This comment has been minimized.
This comment has been minimized.
I'm here because I would like to use arrow, but get the error mentioned here, which I hope will be solved with this MR 🙂 |
@Jean1995 Not yet but we'll get to it after this one is merged (or sooner). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mpimenov thanks for your contribution and your patience
Can anyone take a look at this please?
It usually takes us a few days before we can properly review PRs with lots of changes :)
I have one minor question before merging, but the PR itself looks good for now!
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 6 (
Conan v2 pipeline ❌
The v2 pipeline failed. Please, review the errors and note this will be required for pull requests to be merged in the near future. See details:Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
I suggest a revival of #15983 to use it as a starting point for further improvements. See discussion in the original PR.