[fix] Arrow: Make it conan v2 comaptible, refactor auto options and add 12.0.1 version #19380
Conversation
danimtb
changed the title
ghost
mentioned this pull request
|
I detected other pull requests that are modifying arrow/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
| @@ -49,8 +49,9 @@ class ArrowConan(ConanFile): | |||
| "with_glog": ["auto", True, False], | |||
| "with_grpc": ["auto", True, False], | |||
| "with_jemalloc": ["auto", True, False], | |||
| "with_mimalloc": ["auto", True, False], | |||
There was a problem hiding this comment.
I removed the "auto" value here as there was no real automatic management in place for this options and I didn't investigate the library's build system to know about it. I think it is fine as is.
| "with_json": [True, False], | ||
| "with_thrift": ["auto", True, False], |
There was a problem hiding this comment.
this option did not exist and was conditional to other one. I think it is clear to have it as a real option.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 2 (
Conan v2 pipeline ✔️
All green in build 2 (
|
…uto options and add 12.0.1 version * arrow: add version 12.0.1, with dirty workaround for conan v2 * [fix] Arrow: Make it conan v2 comaptible, refactor auto options and add 12.0.1 * remove prints --------- Co-authored-by: toge <toge.mail@gmail.com>
| self.options.parquet = self._parquet() | ||
| self.options.compute = self._compute() | ||
| self.options.dataset_modules = self._dataset_modules() | ||
| self.options.with_boost = self._with_boost() | ||
| self.options.with_flight_rpc = self._with_flight_rpc() | ||
| self.options.with_gflags = self._with_gflags() | ||
| self.options.with_glog = self._with_glog() | ||
| self.options.with_grpc = self._with_grpc() | ||
| self.options.with_jemalloc = self._with_jemalloc() | ||
| self.options.with_thrift = self._with_thrift() | ||
| self.options.with_llvm = self._with_llvm() | ||
| self.options.with_openssl = self._with_openssl() | ||
| self.options.with_protobuf = self._with_protobuf() | ||
| self.options.with_re2 = self._with_re2() | ||
| self.options.with_utf8proc = self._with_utf8proc() |
There was a problem hiding this comment.
I just want to mention that all this logic is broken, since all these functions try to access options values which don't even exist at config_options() time.
You could set all default values of these options to False, you would get the same result.
There was a problem hiding this comment.
what is the proper way to define dependencies between options in conan 2?
Specify library name and version: arrow/*
Includes changes from and closes #18106
I wanted to fix the workaround proposed at #18106, but it turned out to be more complex than expected due to the logic implemented in the recipe.
I tried to simplify the management of the "auto" options following these rules:
cc/ @toge