-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow: fix self.options and self.settings access in package_id() #19296
Conversation
I detected other pull requests that are modifying arrow/all recipe:
This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
I'm not sure if the same would apply in the case of the I'm not sure auto has much value here, but this PR looks a like a good compromise, albeit an unfortunate one to have to make! |
Hi! I didn't know there was a PR already addressing this issue. I opened one myself #19296 trying to refactor the recipe around this options issue. Please let me know what you think, thanks! |
self.options
andself.settings
can no longer be accessed frompackage_id()
in Conan v2.I'm very open to suggestions if anybody has a better solution.