Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Port from CDP to BiDi browser automation #20832

Merged
merged 7 commits into from
Aug 13, 2024

Conversation

martinpitt
Copy link
Member

@martinpitt martinpitt commented Aug 2, 2024

Follow-ups:

@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Aug 2, 2024
test/common/testlib.py Fixed Show fixed Hide fixed
@martinpitt

This comment was marked as resolved.

@martinpitt

This comment was marked as resolved.

martinpitt added a commit to martinpitt/cockpit-ostree that referenced this pull request Aug 13, 2024
See cockpit-project/cockpit#20832

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.
martinpitt added a commit to cockpit-project/cockpit-podman that referenced this pull request Aug 13, 2024
See cockpit-project/cockpit#20832

Drop chrome-remote-interface NPM dependency.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

Also sort package.json properly (done by `npm install --save-dev`).
martinpitt added a commit to martinpitt/cockpit-machines that referenced this pull request Aug 13, 2024
See cockpit-project/cockpit#20832

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

This causes some minor pixel test noise, adjust the references.
allisonkarlitskaya pushed a commit to cockpit-project/starter-kit that referenced this pull request Aug 13, 2024
See cockpit-project/cockpit#20832

Drop chrome-remote-interface NPM dependency.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.
allisonkarlitskaya pushed a commit to cockpit-project/cockpit-files that referenced this pull request Aug 13, 2024
See cockpit-project/cockpit#20832

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

Adjust `waitDownloadFile()` to the new download directory attribute.
This is a `Path` object now, which is more convenient.
martinpitt added a commit to martinpitt/cockpit-ostree that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.
martinpitt added a commit to martinpitt/cockpit-machines that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

This causes some minor pixel test noise, adjust the references.
martinpitt added a commit to martinpitt/cockpit-machines that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

This causes some minor pixel test noise, adjust the references.
KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832

Drop chrome-remote-interface NPM dependency.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.
martinpitt added a commit to cockpit-project/cockpit-ostree that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.
martinpitt added a commit to cockpit-project/cockpit-machines that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

This causes some minor pixel test noise, adjust the references.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 14, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Aug 15, 2024
See cockpit-project/cockpit#20832

Drop chrome-remote-interface NPM dependency.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

Adjust the exception handling tests to not wait for RuntimeError, this
is no longer raised.
KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Aug 15, 2024
See cockpit-project/cockpit#20832

Drop chrome-remote-interface NPM dependency.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

Adjust the exception handling tests to not wait for RuntimeError, this
is no longer raised.
KKoukiou added a commit to KKoukiou/anaconda-webui that referenced this pull request Aug 15, 2024
See cockpit-project/cockpit#20832

Drop chrome-remote-interface NPM dependency.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.

Adjust the exception handling tests to not wait for RuntimeError, this
is no longer raised. Also switch_to_top frame when waiting for the error
dialog (no idea how it worked before).
Lastly make the CockpitJSErrorHandling test nondestructive.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 20, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 20, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 20, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 20, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
croissanne added a commit to croissanne/cockpit-composer that referenced this pull request Aug 20, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
croissanne added a commit to osbuild/cockpit-composer that referenced this pull request Aug 21, 2024
See cockpit-project/cockpit#20832.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a. It was previously used implicitly
through a transient dependency of something else, but our esbuild
po-plugin uses it explicitly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants