Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Port from CDP to BiDi browser automation #20832

Merged
merged 7 commits into from
Aug 13, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ module = [
# test/common
'cdp',
'testlib',
'webdriver_bidi',
]

[tool.pylint]
Expand Down
2 changes: 1 addition & 1 deletion test/common/storagelib.py
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ def dialog_cancel(self):

def dialog_wait_close(self):
# file system operations often take longer than 10s
with self.browser.wait_timeout(max(self.browser.cdp.timeout, 60)):
with self.browser.wait_timeout(max(self.browser.timeout, 60)):
self.browser.wait_not_present('#dialog')

def dialog_check(self, expect):
Expand Down
496 changes: 282 additions & 214 deletions test/common/testlib.py

Large diffs are not rendered by default.

Loading