test: Move from CDP to BiDi #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
the
blocked
|
So, this looks quite okay. testUpload() cannot be run multiple times, but that feels like an unrelated test bug. |
21 tasks
|
I fixed testUpload() in #701, and included it here. |
|
Good, the rest are flakes and changed pixel refs. |
See cockpit-project/cockpit#20832 Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly. Adjust `waitDownloadFile()` to the new download directory attribute. This is a `Path` object now, which is more convenient.
martinpitt
removed
the
blocked
allisonkarlitskaya
approved these changes
Aug 13, 2024
| @@ -37,6 +36,7 @@ | |||
| "eslint-plugin-react": "7.35.0", | |||
| "eslint-plugin-react-hooks": "4.6.2", | |||
| "gettext-parser": "8.0.0", | |||
| "glob": "11.0.0", | |||
There was a problem hiding this comment.
Huh. Could have sworn I had already done that...
Probably in one of my many unmerged PRs ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See cockpit-project/cockpit#20832
Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.
Adjust
waitDownloadFile()to the new download directory attribute.This is a
Pathobject now, which is more convenient.