Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Move from CDP to BiDi #949

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

martinpitt
Copy link
Member

See cockpit-project/cockpit#20832

Drop chrome-remote-interface NPM dependency.

Explicitly add a "glob" devDependency to follow suit with cockpit-project/cockpit@680decc155a It was previously used implicitly through a transient dependency of something else, but our esbuild po-plugin uses it explicitly.

See cockpit-project/cockpit#20832

Drop chrome-remote-interface NPM dependency.

Explicitly add a "glob" devDependency to follow suit with
cockpit-project/cockpit@680decc155a
It was previously used implicitly through a transient dependency of
something else, but our esbuild po-plugin uses it explicitly.
Copy link
Member

@allisonkarlitskaya allisonkarlitskaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, that was straightforward.

@allisonkarlitskaya allisonkarlitskaya merged commit 44619eb into cockpit-project:main Aug 13, 2024
23 checks passed
@martinpitt martinpitt deleted the bidi-test branch August 13, 2024 11:29
@justin-stephenson
Copy link
Contributor

Hi @martinpitt What about mentions of chrome-remote-interface in https://github.com/cockpit-project/starter-kit/blob/main/test/browser/run-test.sh ?

@martinpitt
Copy link
Member Author

@justin-stephenson whoops, thanks! → #950

But good that I have you "on the line". This needs some action in c-session-recording, please see https://lists.fedorahosted.org/archives/list/cockpit-devel@lists.fedorahosted.org/thread/PUY5X5DT37LLGZRKK6ZZ6T2EOXLQXYPQ/

@justin-stephenson
Copy link
Contributor

@justin-stephenson whoops, thanks! → #950

But good that I have you "on the line". This needs some action in c-session-recording, please see https://lists.fedorahosted.org/archives/list/cockpit-devel@lists.fedorahosted.org/thread/PUY5X5DT37LLGZRKK6ZZ6T2EOXLQXYPQ/

I saw your mail - We will take care of it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants