This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
chore(Jest): setup migration #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoischalifour
approved these changes
Apr 25, 2019
Haroenv
reviewed
Apr 25, 2019
|
@Haroenv Yes it's expected it's only the Jest setup. |
* chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
Closed
Haroenv
pushed a commit
that referenced
this pull request
May 7, 2019
* chore(Jest): functions + hierarchical-facets [PART-1] (#660) * chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
Haroenv
pushed a commit
that referenced
this pull request
May 7, 2019
* chore(Jest): functions + hierarchical-facets [PART-1] (#660) * chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
Haroenv
added a commit
that referenced
this pull request
May 7, 2019
* 2.27.0 - 2019-04-12 4939f6f, closes #640 #646 * Update README.md 059481d * chore(build): add source map support (#654) 42ea2d5 * chore(deps): update dependency algolia-frontend-components to v0.0.35 (#605) 41043af * chore(deps): update dependency algoliasearch to v3.32.0 (#628) e5cab52 * chore(deps): update dependency babel-core to v6.26.3 (#581) 051075c * chore(deps): update dependency browserify to v14.5.0 (#582) 66e2a79 * chore(deps): update dependency handlebars to v4.1.0 (#589) bf1c493 * chore(deps): update dependency http-server to v0.11.1 (#590) 673ee5f * chore: use only yarn (no more npm 👩🚒) (#637) dba85a0 * chore(deps): update dependency mversion to v1.13.0 (#630) 1304f19 * chore(deps): update dependency rimraf to v2.6.3 (#596) 5e17830 * chore(deps): update st (#625) 5d7d915 * chore(docs): change jade to pug (#615) 80a20dc, closes #613 * chore(docs): fix interpolation dd888f2 * chore(docs): remove folder in (#616) 7bfc971 * chore(Jest): enable typeahead plugin (#668) 029e11c * chore(Jest): setup migration (#659) 2bf5e10 * chore(Travis): build all branches (#669) bc2eb18 * ci(test): Travis → Circle (#671) 2442ab0 * docs(init): use toggleFacetRefinement instead (#622) 2461ffe * docs(instantiate): use existing signature of toggleRefine (#621) 6be5ec1 * docs: fix InstantSearch link (#640) 2c97a71, closes #640 * docs: fix typo on hierarchical facets (#646) ee5b3b4, closes #646 * feat(sffv): throw an error if it's called and the client doesn't have the functions (#623) dd61360 * fix(ua): change the User-Agent to use the new specs lib (version) (#647) eafd4cf * refactor(events): replace util.inherits by inline (#653) 16459ae * test(client): update index name (#619) 3564274
Haroenv
pushed a commit
that referenced
this pull request
May 7, 2019
* chore(Jest): functions + hierarchical-facets [PART-1] (#660) * chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
Haroenv
added a commit
that referenced
this pull request
May 7, 2019
* chore(Jest): functions + hierarchical-facets [PART-1] (#660) * chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* chore(Jest): functions + hierarchical-facets [PART-1] (algolia/algoliasearch-helper-js#660) * chore(Jest): SearchParameters [PART-2] (algolia/algoliasearch-helper-js#661) * chore(Jest): SearchResults [PART-3] (algolia/algoliasearch-helper-js#662) * chore(Jest): algoliasearch.helper [PART-4] (algolia/algoliasearch-helper-js#663) * chore(Jest): top level spec [PART-5] (algolia/algoliasearch-helper-js#664) * chore(Jest): integration [PART-6] (algolia/algoliasearch-helper-js#665) * chore(Jest): runner [PART-7] (algolia/algoliasearch-helper-js#666) * chore(Jest): cleanup [PART-8] (algolia/algoliasearch-helper-js#667)
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* 2.27.0 - 2019-04-12 algolia/algoliasearch-helper-js@67a07c1, closes algolia/algoliasearch-helper-js#640 algolia/algoliasearch-helper-js#646 * Update README.md algolia/algoliasearch-helper-js@6c40a66 * chore(build): add source map support (algolia/algoliasearch-helper-js#654) algolia/algoliasearch-helper-js@25635fc * chore(deps): update dependency algolia-frontend-components to v0.0.35 (algolia/algoliasearch-helper-js#605) algolia/algoliasearch-helper-js@0bb3578 * chore(deps): update dependency algoliasearch to v3.32.0 (algolia/algoliasearch-helper-js#628) algolia/algoliasearch-helper-js@39cb552 * chore(deps): update dependency babel-core to v6.26.3 (algolia/algoliasearch-helper-js#581) algolia/algoliasearch-helper-js@83213d7 * chore(deps): update dependency browserify to v14.5.0 (algolia/algoliasearch-helper-js#582) algolia/algoliasearch-helper-js@855cf5d * chore(deps): update dependency handlebars to v4.1.0 (algolia/algoliasearch-helper-js#589) algolia/algoliasearch-helper-js@28fd11b * chore(deps): update dependency http-server to v0.11.1 (algolia/algoliasearch-helper-js#590) algolia/algoliasearch-helper-js@9534c17 * chore: use only yarn (no more npm 👩🚒) (algolia/algoliasearch-helper-js#637) algolia/algoliasearch-helper-js@b5b0952 * chore(deps): update dependency mversion to v1.13.0 (algolia/algoliasearch-helper-js#630) algolia/algoliasearch-helper-js@20dce48 * chore(deps): update dependency rimraf to v2.6.3 (algolia/algoliasearch-helper-js#596) algolia/algoliasearch-helper-js@0ed5fa9 * chore(deps): update st (algolia/algoliasearch-helper-js#625) algolia/algoliasearch-helper-js@81a30b5 * chore(docs): change jade to pug (algolia/algoliasearch-helper-js#615) algolia/algoliasearch-helper-js@f1ef3b0, closes algolia/algoliasearch-helper-js#613 * chore(docs): fix interpolation algolia/algoliasearch-helper-js@d591977 * chore(docs): remove folder in (algolia/algoliasearch-helper-js#616) algolia/algoliasearch-helper-js@0e9332f * chore(Jest): enable typeahead plugin (algolia/algoliasearch-helper-js#668) algolia/algoliasearch-helper-js@e88c115 * chore(Jest): setup migration (algolia/algoliasearch-helper-js#659) algolia/algoliasearch-helper-js@6dfb8ad * chore(Travis): build all branches (algolia/algoliasearch-helper-js#669) algolia/algoliasearch-helper-js@0c27d0b * ci(test): Travis → Circle (algolia/algoliasearch-helper-js#671) algolia/algoliasearch-helper-js@7b9c540 * docs(init): use toggleFacetRefinement instead (algolia/algoliasearch-helper-js#622) algolia/algoliasearch-helper-js@d07614b * docs(instantiate): use existing signature of toggleRefine (algolia/algoliasearch-helper-js#621) algolia/algoliasearch-helper-js@c35bec9 * docs: fix InstantSearch link (algolia/algoliasearch-helper-js#640) algolia/algoliasearch-helper-js@66dfa0c, closes algolia/algoliasearch-helper-js#640 * docs: fix typo on hierarchical facets (algolia/algoliasearch-helper-js#646) algolia/algoliasearch-helper-js@940e2c6, closes algolia/algoliasearch-helper-js#646 * feat(sffv): throw an error if it's called and the client doesn't have the functions (algolia/algoliasearch-helper-js#623) algolia/algoliasearch-helper-js@9002c31 * fix(ua): change the User-Agent to use the new specs lib (version) (algolia/algoliasearch-helper-js#647) algolia/algoliasearch-helper-js@ec2c6ee * refactor(events): replace util.inherits by inline (algolia/algoliasearch-helper-js#653) algolia/algoliasearch-helper-js@0e227f9 * test(client): update index name (algolia/algoliasearch-helper-js#619) algolia/algoliasearch-helper-js@ba68a3c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards the migration to Jest. It setups the configuration/requirement for Jest to run on the project. The PRs that follow migrate the tests folder by folder to limit the amount of lines to review.
sanethat Jest relies on.test/spec) by default. To run the unit + integration we have to use thetestcommand. It eases the development workflow to only runs the unit test from the CLI.jestenv used on this version does not include thetestidentifier, that's why I've enabled it. Only thetestfolder is impacted by the change.