Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

chore(Jest): runner [PART-7] #666

Merged
merged 4 commits into from
Apr 29, 2019
Merged

chore(Jest): runner [PART-7] #666

merged 4 commits into from
Apr 29, 2019

Conversation

samouss
Copy link
Contributor

@samouss samouss commented Apr 25, 2019

This PR updates the test runner that was implemented with tape. We use the exact same behaviour than before expect that now both unit and integration tests run with jest. You can run the unit tests locally with:

yarn test

To run both unit and integration tests:

INTEGRATION_TEST_API_KEY=yourApiKey \
INTEGRATION_TEST_APPID=yourAppId \
yarn test

I've increased the default timeout to 15000 only when the integration tests are expected to run. By default tape does not timeout on async test but jest does. I've tested multiple times with this value it worked. We can increase it a bit more if we have flakiness issues.

@samouss samouss requested a review from a team April 25, 2019 16:03
@Haroenv
Copy link
Contributor

Haroenv commented Apr 26, 2019

Travis doesn't run here because the target branch isn't develop :(

Haroenv
Haroenv reviewed Apr 26, 2019
View reviewed changes
test/run.js Show resolved Hide resolved
francoischalifour
francoischalifour reviewed Apr 26, 2019
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we use Node 8 now we could use a newer syntax.

We can't check for sure that it works on Travis though since it's not running.

test/run.js Outdated Show resolved Hide resolved
@samouss
Copy link
Contributor Author

samouss commented Apr 26, 2019

Since we use Node 8 now we could use a newer syntax.

#666 (comment)

We can't check for sure that it works on Travis though since it's not running.

Yes indeed. Travis is set up to only runs on develop & master. It would be solved once the PRs are merged into one and targets develop. I've opened a PR #658 (CI) to fire Travis yesterday to check that the CI passed.

@samouss samouss mentioned this pull request Apr 26, 2019
Merged
francoischalifour
francoischalifour approved these changes Apr 26, 2019
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#️⃣6️⃣6️⃣6️⃣

@samouss samouss merged commit a3678d2 into chore/jest-6-integration Apr 29, 2019
@samouss samouss deleted the chore/jest-7-runner branch April 29, 2019 08:27
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): integration [PART-6] (#665)
a5ac6d4 
* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): top level spec [PART-5] (#664)
c5b872a 
* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): algoliasearch.helper [PART-4] (#663)
f5ade29 
* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): SearchResults [PART-3] (#662)
4656373 
* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): SearchParameters [PART-2] (#661)
f62d80f 
* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): functions + hierarchical-facets [PART-1] (#660)
ed31233 
* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): setup migration (#659)
633c241 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
Haroenv pushed a commit that referenced this pull request May 7, 2019
@samouss @Haroenv
chore(Jest): setup migration (#659)
ea841f9 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
Haroenv pushed a commit that referenced this pull request May 7, 2019
@samouss @Haroenv
chore(Jest): setup migration (#659)
2bf5e10 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
Haroenv pushed a commit that referenced this pull request May 7, 2019
@samouss @Haroenv
chore(Jest): setup migration (#659)
52ff5d9 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
Haroenv added a commit that referenced this pull request May 7, 2019
@Haroenv
chore(Jest): setup migration (#659)
1cacc32 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
@samouss @Haroenv
chore(Jest): setup migration (algolia/algoliasearch-helper-js#659)
b02e6c7 
* chore(Jest): functions + hierarchical-facets [PART-1] (algolia/algoliasearch-helper-js#660)

* chore(Jest): SearchParameters [PART-2] (algolia/algoliasearch-helper-js#661)

* chore(Jest): SearchResults [PART-3] (algolia/algoliasearch-helper-js#662)

* chore(Jest): algoliasearch.helper [PART-4] (algolia/algoliasearch-helper-js#663)

* chore(Jest): top level spec [PART-5] (algolia/algoliasearch-helper-js#664)

* chore(Jest): integration [PART-6] (algolia/algoliasearch-helper-js#665)

* chore(Jest): runner [PART-7] (algolia/algoliasearch-helper-js#666)

* chore(Jest): cleanup [PART-8] (algolia/algoliasearch-helper-js#667)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Haroenv Haroenv Haroenv left review comments

@francoischalifour francoischalifour francoischalifour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samouss @Haroenv @francoischalifour