Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

chore(Jest): algoliasearch.helper [PART-4] #663

Merged
merged 4 commits into from
Apr 29, 2019
Merged

chore(Jest): algoliasearch.helper [PART-4] #663

merged 4 commits into from
Apr 29, 2019

Conversation

samouss
Copy link
Contributor

@samouss samouss commented Apr 25, 2019

This PR moves the folder test/spec/algoliasearch.helper to Jest. You can run the test locally with:

yarn jest test/spec/algoliasearch.helper

The migration has been done by jest-codemods (recommended by the Jest project) for all the assertions. Then I removed the dependency on sinon file by file. I tried to didn't update the code style or anything unless it was too complicated to migrate.

@samouss samouss requested a review from a team April 25, 2019 15:13
francoischalifour
francoischalifour reviewed Apr 25, 2019
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added possible improvements to be added in all the files.

test/spec/algoliasearch.helper/clears.js Show resolved Hide resolved
test/spec/algoliasearch.helper/client.js Show resolved Hide resolved
test/spec/algoliasearch.helper/client.js Show resolved Hide resolved
test/spec/algoliasearch.helper/derive/detach.js Show resolved Hide resolved
test/spec/algoliasearch.helper/distinct.js Show resolved Hide resolved
test/spec/algoliasearch.helper/getQueryParameter.js Show resolved Hide resolved
test/spec/algoliasearch.helper/incorrectFacetDefinition.js Outdated Show resolved Hide resolved
test/spec/algoliasearch.helper/incorrectFacetDefinition.js Show resolved Hide resolved
test/spec/algoliasearch.helper/numericFilters.js Show resolved Hide resolved
test/spec/algoliasearch.helper/pages.js Show resolved Hide resolved
francoischalifour
francoischalifour approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can tackle the suggested ameliorations later on.

francoischalifour and others added 2 commits April 25, 2019 18:32
@francoischalifour @samouss
test: Conjuctive -> Conjunctive
bcd173b 
Co-Authored-By: samouss <samuel.vllnt@gmail.com>
@samouss
chore(Jest): top level spec [PART-5] (#664)
c5b872a 
* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
@samouss samouss merged commit f5ade29 into chore/jest-3-search-results Apr 29, 2019
@samouss samouss deleted the chore/jest-4-algoliasearch-helper branch April 29, 2019 08:28
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): SearchResults [PART-3] (#662)
4656373 
* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): SearchParameters [PART-2] (#661)
f62d80f 
* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): functions + hierarchical-facets [PART-1] (#660)
ed31233 
* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
samouss added a commit that referenced this pull request Apr 29, 2019
@samouss
chore(Jest): setup migration (#659)
633c241 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
Haroenv pushed a commit that referenced this pull request May 7, 2019
@samouss @Haroenv
chore(Jest): setup migration (#659)
ea841f9 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
Haroenv pushed a commit that referenced this pull request May 7, 2019
@samouss @Haroenv
chore(Jest): setup migration (#659)
2bf5e10 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
Haroenv pushed a commit that referenced this pull request May 7, 2019
@samouss @Haroenv
chore(Jest): setup migration (#659)
52ff5d9 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
Haroenv added a commit that referenced this pull request May 7, 2019
@Haroenv
chore(Jest): setup migration (#659)
1cacc32 
* chore(Jest): functions + hierarchical-facets [PART-1] (#660)

* chore(Jest): SearchParameters [PART-2] (#661)

* chore(Jest): SearchResults [PART-3] (#662)

* chore(Jest): algoliasearch.helper [PART-4] (#663)

* chore(Jest): top level spec [PART-5] (#664)

* chore(Jest): integration [PART-6] (#665)

* chore(Jest): runner [PART-7] (#666)

* chore(Jest): cleanup [PART-8] (#667)
dhayab pushed a commit to algolia/instantsearch that referenced this pull request Jul 10, 2023
@samouss @Haroenv
chore(Jest): setup migration (algolia/algoliasearch-helper-js#659)
b02e6c7 
* chore(Jest): functions + hierarchical-facets [PART-1] (algolia/algoliasearch-helper-js#660)

* chore(Jest): SearchParameters [PART-2] (algolia/algoliasearch-helper-js#661)

* chore(Jest): SearchResults [PART-3] (algolia/algoliasearch-helper-js#662)

* chore(Jest): algoliasearch.helper [PART-4] (algolia/algoliasearch-helper-js#663)

* chore(Jest): top level spec [PART-5] (algolia/algoliasearch-helper-js#664)

* chore(Jest): integration [PART-6] (algolia/algoliasearch-helper-js#665)

* chore(Jest): runner [PART-7] (algolia/algoliasearch-helper-js#666)

* chore(Jest): cleanup [PART-8] (algolia/algoliasearch-helper-js#667)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@francoischalifour francoischalifour francoischalifour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samouss @francoischalifour