This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
chore(Jest): SearchParameters [PART-2] #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoischalifour
approved these changes
Apr 25, 2019
samouss
added a commit
that referenced
this pull request
Apr 29, 2019
* chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
samouss
added a commit
that referenced
this pull request
Apr 29, 2019
* chore(Jest): functions + hierarchical-facets [PART-1] (#660) * chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
Haroenv
pushed a commit
that referenced
this pull request
May 7, 2019
* chore(Jest): functions + hierarchical-facets [PART-1] (#660) * chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
Haroenv
pushed a commit
that referenced
this pull request
May 7, 2019
* chore(Jest): functions + hierarchical-facets [PART-1] (#660) * chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
Haroenv
pushed a commit
that referenced
this pull request
May 7, 2019
* chore(Jest): functions + hierarchical-facets [PART-1] (#660) * chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
Haroenv
added a commit
that referenced
this pull request
May 7, 2019
* chore(Jest): functions + hierarchical-facets [PART-1] (#660) * chore(Jest): SearchParameters [PART-2] (#661) * chore(Jest): SearchResults [PART-3] (#662) * chore(Jest): algoliasearch.helper [PART-4] (#663) * chore(Jest): top level spec [PART-5] (#664) * chore(Jest): integration [PART-6] (#665) * chore(Jest): runner [PART-7] (#666) * chore(Jest): cleanup [PART-8] (#667)
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* chore(Jest): functions + hierarchical-facets [PART-1] (algolia/algoliasearch-helper-js#660) * chore(Jest): SearchParameters [PART-2] (algolia/algoliasearch-helper-js#661) * chore(Jest): SearchResults [PART-3] (algolia/algoliasearch-helper-js#662) * chore(Jest): algoliasearch.helper [PART-4] (algolia/algoliasearch-helper-js#663) * chore(Jest): top level spec [PART-5] (algolia/algoliasearch-helper-js#664) * chore(Jest): integration [PART-6] (algolia/algoliasearch-helper-js#665) * chore(Jest): runner [PART-7] (algolia/algoliasearch-helper-js#666) * chore(Jest): cleanup [PART-8] (algolia/algoliasearch-helper-js#667)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the folder
test/spec/SearchParametersto Jest. You can run the tests locally with:The migration has been done by
jest-codemods(recommended by the Jest project) for all the assertions. Then I removed the dependency onsinonfile by file. I tried to didn't update the code style or anything unless it was too complicated to migrate.